8340181: Shenandoah: Cleanup ShenandoahRuntime stubs#21152
8340181: Shenandoah: Cleanup ShenandoahRuntime stubs#21152shipilev wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 80 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
adinn
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up. Looks good.
phohensee
left a comment
There was a problem hiding this comment.
In case you need a second review.
|
/integrate |
|
Going to push as commit 988a531.
Your commit was automatically rebased without conflicts. |
Noticed this while working on Leyden, which has to enumerate Shenandoah stubs for code archival to work.
ShenandoahRuntime::shenandoah_clone_barrieris excessive name.ShenandoahRuntime::arraycopy_barrier_oop_entryand friends is not covered byJRT_LEAF. This change hopefully homogenizes the namings for the stubs.Additional testing:
hotspot_gc_shenandoahhotspot_gc_shenandoahProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21152/head:pull/21152$ git checkout pull/21152Update a local copy of the PR:
$ git checkout pull/21152$ git pull https://git.openjdk.org/jdk.git pull/21152/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21152View PR using the GUI difftool:
$ git pr show -t 21152Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21152.diff
Webrev
Link to Webrev Comment