Skip to content

8340181: Shenandoah: Cleanup ShenandoahRuntime stubs#21152

Closed
shipilev wants to merge 2 commits intoopenjdk:masterfrom
shipilev:JDK-8340181-shenandoah-cleanup-stubs
Closed

8340181: Shenandoah: Cleanup ShenandoahRuntime stubs#21152
shipilev wants to merge 2 commits intoopenjdk:masterfrom
shipilev:JDK-8340181-shenandoah-cleanup-stubs

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Sep 24, 2024

Noticed this while working on Leyden, which has to enumerate Shenandoah stubs for code archival to work.

ShenandoahRuntime::shenandoah_clone_barrier is excessive name. ShenandoahRuntime::arraycopy_barrier_oop_entry and friends is not covered by JRT_LEAF. This change hopefully homogenizes the namings for the stubs.

Additional testing:

  • Linux x86_64 server fastdebug, hotspot_gc_shenandoah
  • Linux AArch64 server fastdebug, hotspot_gc_shenandoah

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340181: Shenandoah: Cleanup ShenandoahRuntime stubs (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21152/head:pull/21152
$ git checkout pull/21152

Update a local copy of the PR:
$ git checkout pull/21152
$ git pull https://git.openjdk.org/jdk.git pull/21152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21152

View PR using the GUI difftool:
$ git pr show -t 21152

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21152.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340181: Shenandoah: Cleanup ShenandoahRuntime stubs

Reviewed-by: adinn, phh, wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

  • 12de4fb: 8340826: Should not send unload notification for scratch classes
  • 25e8929: 8340620: Fix -Wzero-as-null-pointer-constant warnings for CompressedOops
  • 6587909: 8341015: OopStorage location decoder crashes accessing non-initalized OopStorage
  • 9003e2c: 8341027: Crash in java/runtime/Unsafe/InternalErrorTest when running with -XX:-UseCompressedClassPointers
  • 2a2ecc9: 8339475: Clean up return code handling for pthread calls in library coding
  • 85dba47: 8325090: javadoc fails when -subpackages option is used with non-modular -source
  • 1bc13a1: 8340552: Harden TzdbZoneRulesCompiler against missing zone names
  • e6373b5: 8340679: Misc tests fail assert(!set || SafepointSynchronize::is_at_safepoint()) failed: set once or at safepoint
  • 2349bb7: 8340974: Ambiguous name of jtreg property vm.libgraal.enabled
  • 5d062e2: 8340576: Some JVMCI flags are inconsistent
  • ... and 70 more: https://git.openjdk.org/jdk/compare/ea8f35b98e618bfa55371e45b3ef61fa5289dd94...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Sep 24, 2024
@shipilev shipilev marked this pull request as ready for review September 24, 2024 11:14
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 24, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 24, 2024

Webrevs

Copy link
Contributor

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up. Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 25, 2024
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you need a second review.

@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

Going to push as commit 988a531.
Since your change was applied there have been 94 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 30, 2024
@openjdk openjdk bot closed this Sep 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 30, 2024
@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@shipilev Pushed as commit 988a531.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8340181-shenandoah-cleanup-stubs branch January 8, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

4 participants