8340899: Remove wildcard bound in PositionWindows.positionTestWindows

[aivanov-jdk]

Removes the wildcard bound from PassFailJFrame.PositionWindows.positionTestWindows so that implementing the interface is simpler as one don't have to remember to declare the testWindows parameter as List<? extends Window> — just use List<Window>.

It is a backwards compatible change, all the tests which use List<? extends Window> continue to compile successfully.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340899: Remove wildcard bound in PositionWindows.positionTestWindows (Bug - P3)

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer)
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21181/head:pull/21181
$ git checkout pull/21181

Update a local copy of the PR:
$ git checkout pull/21181
$ git pull https://git.openjdk.org/jdk.git pull/21181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21181

View PR using the GUI difftool:
$ git pr show -t 21181

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21181.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340899: Remove wildcard bound in PositionWindows.positionTestWindows

Reviewed-by: azvegint, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

• 8f75619: 8340864: Remove unused lines related to vmClasses
• 84751cb: 8340831: Simplify simple validation for class definition in MethodHandles.Lookup
• df1959f: 8340838: Clean up MutableCallSite to use explicit release fence instead of AtomicInteger
• 1b2d40a: 8340956: ProblemList 4 java/nio/channels/DatagramChannel tests on macosx-all
• f7bc9ba: 8340228: Open source couple more miscellaneous AWT tests
• 0e0b0b0: 8340684: Reading from an input stream backed by a closed ZipFile has no test coverage
• 81b5f09: 8340946: Add vmTestbase/gc/memory/Nio/Nio.java and java/nio/Buffer/LimitDirectMemory.java to problem list
• 0474f02: 8340815: Add SECURITY.md file
• fb70325: 8338583: NMT: Malloc overhead is calculated incorrectly
• 083b980: 8340568: Incorrect escaping of single quotes when pretty-printing character literals
• ... and 38 more: https://git.openjdk.org/jdk/compare/e97f0fe1b4046bfcc40e85ba1bee4f4c40053300...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0f615a15)

[aivanov-jdk]

You can test this change with tests from #21180 DefaultFrameIconTest.java and/or MenuCrash.java.

The tests declare the first parameter to positionTestWindows as List<? extends Window> testWindows. If it were declared as List<Window> testWindows, the test would not compile with the current version of PassFailJFrame.

Removing the wildcard lower bound from PassFailJFrame.PositionWindows.positionTestWindows makes it possible to use the List<Window> type in tests.

[aivanov-jdk]

/integrate

[openjdk]

Going to push as commit e2626db.
Since your change was applied there have been 52 commits pushed to the master branch:

• 10da2c2: 8340923: The class LogSelection copies uninitialized memory
• 8c8f0d8: 8339260: Move rarely used constants out of ClassFile
• 47c1069: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe
• 66f1639: 8339271: giflib attribution correction
• 8f75619: 8340864: Remove unused lines related to vmClasses
• 84751cb: 8340831: Simplify simple validation for class definition in MethodHandles.Lookup
• df1959f: 8340838: Clean up MutableCallSite to use explicit release fence instead of AtomicInteger
• 1b2d40a: 8340956: ProblemList 4 java/nio/channels/DatagramChannel tests on macosx-all
• f7bc9ba: 8340228: Open source couple more miscellaneous AWT tests
• 0e0b0b0: 8340684: Reading from an input stream backed by a closed ZipFile has no test coverage
• ... and 42 more: https://git.openjdk.org/jdk/compare/e97f0fe1b4046bfcc40e85ba1bee4f4c40053300...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit e2626db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.