Skip to content

8340560: Open Source several AWT/2D font and rendering tests#21192

Closed
prrace wants to merge 1 commit intoopenjdk:masterfrom
prrace:2d_tests_5
Closed

8340560: Open Source several AWT/2D font and rendering tests#21192
prrace wants to merge 1 commit intoopenjdk:masterfrom
prrace:2d_tests_5

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Sep 25, 2024

Open sourcing some rendering tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340560: Open Source several AWT/2D font and rendering tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21192/head:pull/21192
$ git checkout pull/21192

Update a local copy of the PR:
$ git checkout pull/21192
$ git pull https://git.openjdk.org/jdk.git pull/21192/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21192

View PR using the GUI difftool:
$ git pr show -t 21192

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21192.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2024

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 25, 2024

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340560: Open Source several AWT/2D font and rendering tests

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 104 new commits pushed to the master branch:

  • 73ebb84: 8340721: Clarify special case handling of unboxedType and getWildcardType
  • ed140f5: 8341101: [ARM32] Error: ShouldNotReachHere() in TemplateInterpreterGenerator::generate_math_entry after 8338694
  • 082125d: 8340404: CharsetProvider specification updates
  • a7bfced: 8337679: Memset warning in src/hotspot/share/adlc/adlArena.cpp
  • f554c3f: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 65200a9: 8340490: Shenandoah: Optimize ShenandoahPacer
  • 824a297: 8341057: Add 2 SSL.com TLS roots
  • 5aae3d4: 8341096: ProblemList compiler/cha/TypeProfileFinalMethod.java in Xcomp mode
  • 68c4f36: 8340024: In ClassReader, extract a constant for the superclass supertype_index
  • 12de4fb: 8340826: Should not send unload notification for scratch classes
  • ... and 94 more: https://git.openjdk.org/jdk/compare/64275e6bbf1377c9a9d77fe3c3ed8d4143138f11...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8340560 8340560: Open Source several AWT/2D font and rendering tests Sep 25, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 25, 2024
@openjdk
Copy link

openjdk bot commented Sep 25, 2024

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 25, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2024

Webrevs

static void checkString(String script, String str) {
int index = font.canDisplayUpTo(str);
if (index != -1) {
throw new RuntimeException("Cannot display char " + index + " for " + script);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new RuntimeException("Cannot display char " + index + " for " + script);
throw new RuntimeException("Cannot display char " + index + " for " + script);

Copy link
Member

@azuev-java azuev-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 28, 2024
@prrace
Copy link
Contributor Author

prrace commented Sep 29, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 29, 2024

Going to push as commit ade17ec.
Since your change was applied there have been 104 commits pushed to the master branch:

  • 73ebb84: 8340721: Clarify special case handling of unboxedType and getWildcardType
  • ed140f5: 8341101: [ARM32] Error: ShouldNotReachHere() in TemplateInterpreterGenerator::generate_math_entry after 8338694
  • 082125d: 8340404: CharsetProvider specification updates
  • a7bfced: 8337679: Memset warning in src/hotspot/share/adlc/adlArena.cpp
  • f554c3f: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 65200a9: 8340490: Shenandoah: Optimize ShenandoahPacer
  • 824a297: 8341057: Add 2 SSL.com TLS roots
  • 5aae3d4: 8341096: ProblemList compiler/cha/TypeProfileFinalMethod.java in Xcomp mode
  • 68c4f36: 8340024: In ClassReader, extract a constant for the superclass supertype_index
  • 12de4fb: 8340826: Should not send unload notification for scratch classes
  • ... and 94 more: https://git.openjdk.org/jdk/compare/64275e6bbf1377c9a9d77fe3c3ed8d4143138f11...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 29, 2024
@openjdk openjdk bot closed this Sep 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 29, 2024
@openjdk
Copy link

openjdk bot commented Sep 29, 2024

@prrace Pushed as commit ade17ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants