8340560: Open Source several AWT/2D font and rendering tests#21192
8340560: Open Source several AWT/2D font and rendering tests#21192prrace wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 104 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
| static void checkString(String script, String str) { | ||
| int index = font.canDisplayUpTo(str); | ||
| if (index != -1) { | ||
| throw new RuntimeException("Cannot display char " + index + " for " + script); |
There was a problem hiding this comment.
| throw new RuntimeException("Cannot display char " + index + " for " + script); | |
| throw new RuntimeException("Cannot display char " + index + " for " + script); |
|
/integrate |
|
Going to push as commit ade17ec.
Your commit was automatically rebased without conflicts. |
Open sourcing some rendering tests.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21192/head:pull/21192$ git checkout pull/21192Update a local copy of the PR:
$ git checkout pull/21192$ git pull https://git.openjdk.org/jdk.git pull/21192/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21192View PR using the GUI difftool:
$ git pr show -t 21192Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21192.diff
Webrev
Link to Webrev Comment