8339879: Open some dialog awt tests #21196

alisenchung · 2024-09-26T01:11:03Z

First set of dialog swing tests to open during fall 2024 test sprint

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8339879: Open some dialog awt tests (Bug - P4)

Reviewers

Harshitha Onkar (@honkar-jdk - Reviewer)
Phil Race (@prrace - Reviewer) Review applies to c1534adc

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21196/head:pull/21196
$ git checkout pull/21196

Update a local copy of the PR:
$ git checkout pull/21196
$ git pull https://git.openjdk.org/jdk.git pull/21196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21196

View PR using the GUI difftool:
$ git pr show -t 21196

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21196.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-09-26T01:11:42Z

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-09-26T01:13:03Z

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339879: Open some dialog awt tests

Reviewed-by: honkar, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1515 new commits pushed to the master branch:

9e262df: 8342002: sun/security/tools/keytool/GenKeyPairSigner.java failed due to missing certificate output
f56a154: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
ba3774d: 8341637: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)
1581508: 8335091: NMT: VMATree reserve_mapping and commit_mapping APIs need MEMFLAGS while un/-committing API has no MEMFLAGS arg
b20c5c7: 8341967: Unify os::current_file_offset and os::seek_to_file_offset across posix platforms
dcac4b0: 8341471: Reversed field layout caused by unstable sorting
e3f6503: 8341893: AArch64: Micro-optimize compressed ptr decoding
037f11b: 8341708: Optimize safepoint poll encoding with smaller poll data offset
8d0975a: 8336726: C2: assert(!do_asserts || projs->fallthrough_ioproj != nullptr) failed: must be found
fe98f86: 8226938: [TEST_BUG]GTK L&F: There is no Details button in FileChooser Dialog
... and 1505 more: https://git.openjdk.org/jdk/compare/6238bc8da2abe7a1f0cdd98c0af01e9ba1869ec3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-09-26T01:13:54Z

@alisenchung The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-09-26T01:17:36Z

Webrevs

test/jdk/java/awt/Dialog/DialogInitialResizability.java

test/jdk/java/awt/Dialog/ShownModalDialogSerializationTest.java

honkar-jdk

LGTM other than the minor comments

honkar-jdk · 2024-09-27T00:00:39Z

test/jdk/java/awt/Dialog/NestedDialogTest.java

+/*
+ * @test
+ * @bug 4110094 4178930 4178390
+ * @summary Test: Rewrite of Win32 modal dialogs


Suggested change

* @summary Test: Rewrite of Win32 modal dialogs

* @summary Test: Rewrite of Win modal dialogs

honkar-jdk · 2024-09-27T00:01:03Z

test/jdk/java/awt/Dialog/NestedDialogTest.java

+        NestedDialogTest.removeWindow(this);
+        super.dispose();
+    }
+}


missing EOF newline

honkar-jdk · 2024-09-27T00:01:43Z

test/jdk/java/awt/Dialog/DialogInitialResizability.java

+        public void componentHidden(ComponentEvent e) {
+        }
+    }
+}


Missing EOF newline

kumarabhi006 · 2024-10-01T08:01:02Z

@alisenchung Title mismatched..

alisenchung · 2024-10-14T16:45:30Z

/integrate

openjdk · 2024-10-14T16:46:00Z

Going to push as commit 6071346.
Since your change was applied there have been 1516 commits pushed to the master branch:

a8a8b2d: 8341831: PhaseCFG::insert_anti_dependences asserts with "no loads"
9e262df: 8342002: sun/security/tools/keytool/GenKeyPairSigner.java failed due to missing certificate output
f56a154: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
ba3774d: 8341637: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)
1581508: 8335091: NMT: VMATree reserve_mapping and commit_mapping APIs need MEMFLAGS while un/-committing API has no MEMFLAGS arg
b20c5c7: 8341967: Unify os::current_file_offset and os::seek_to_file_offset across posix platforms
dcac4b0: 8341471: Reversed field layout caused by unstable sorting
e3f6503: 8341893: AArch64: Micro-optimize compressed ptr decoding
037f11b: 8341708: Optimize safepoint poll encoding with smaller poll data offset
8d0975a: 8336726: C2: assert(!do_asserts || projs->fallthrough_ioproj != nullptr) failed: must be found
... and 1506 more: https://git.openjdk.org/jdk/compare/6238bc8da2abe7a1f0cdd98c0af01e9ba1869ec3...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-10-14T16:46:09Z

@alisenchung Pushed as commit 6071346.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

moving tests to open

bea55c8

library path change

d3e65e5

openjdk bot added the rfr Pull request is ready for review label Sep 26, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Sep 26, 2024

TejeshR13 reviewed Sep 26, 2024

View reviewed changes

test/jdk/java/awt/Dialog/DialogInitialResizability.java Outdated Show resolved Hide resolved

test/jdk/java/awt/Dialog/DialogInitialResizability.java Outdated Show resolved Hide resolved

test/jdk/java/awt/Dialog/ShownModalDialogSerializationTest.java Show resolved Hide resolved

update jtreg

c1534ad

honkar-jdk approved these changes Sep 27, 2024

View reviewed changes

prrace approved these changes Sep 29, 2024

View reviewed changes

alisenchung changed the title ~~8339879: Open some dialog swing tests~~ 8339879: Open some dialog awt tests Oct 1, 2024

openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2024

add EOF newlines

797ff4c

openjdk bot removed the ready Pull request is ready to be integrated label Oct 14, 2024

honkar-jdk approved these changes Oct 14, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 14, 2024

openjdk bot added the integrated Pull request has been integrated label Oct 14, 2024

openjdk bot closed this Oct 14, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2024

DamonGuy mentioned this pull request Nov 22, 2024

8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main #22026

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8339879: Open some dialog awt tests #21196

8339879: Open some dialog awt tests #21196

alisenchung commented Sep 26, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 26, 2024

openjdk bot commented Sep 26, 2024 •

edited

Loading

openjdk bot commented Sep 26, 2024

mlbridge bot commented Sep 26, 2024 •

edited

Loading

honkar-jdk left a comment

honkar-jdk Sep 27, 2024

honkar-jdk Sep 27, 2024

honkar-jdk Sep 27, 2024

kumarabhi006 commented Oct 1, 2024

alisenchung commented Oct 14, 2024

openjdk bot commented Oct 14, 2024

openjdk bot commented Oct 14, 2024

	* @summary Test: Rewrite of Win32 modal dialogs
	* @summary Test: Rewrite of Win modal dialogs

8339879: Open some dialog awt tests #21196

8339879: Open some dialog awt tests #21196

Conversation

alisenchung commented Sep 26, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Sep 26, 2024

openjdk bot commented Sep 26, 2024 • edited Loading

openjdk bot commented Sep 26, 2024

mlbridge bot commented Sep 26, 2024 • edited Loading

Webrevs

honkar-jdk left a comment

Choose a reason for hiding this comment

honkar-jdk Sep 27, 2024

Choose a reason for hiding this comment

honkar-jdk Sep 27, 2024

Choose a reason for hiding this comment

honkar-jdk Sep 27, 2024

Choose a reason for hiding this comment

kumarabhi006 commented Oct 1, 2024

alisenchung commented Oct 14, 2024

openjdk bot commented Oct 14, 2024

openjdk bot commented Oct 14, 2024

alisenchung commented Sep 26, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Sep 26, 2024 •

edited

Loading

mlbridge bot commented Sep 26, 2024 •

edited

Loading