Skip to content

8340366: Open source several AWT Dialog tests - Batch 3 #21218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

TejeshR13
Copy link
Contributor

@TejeshR13 TejeshR13 commented Sep 27, 2024

Open source these AWT Dialog tests:

java/awt/Dialog/ModalDialogTest.java
java/awt/Dialog/DialogModalityTest.java
java/awt/Dialog/DialogResizeTest2.java
java/awt/Dialog/HideDialogTest.java
java/awt/Dialog/FileDialogUserFilterTest.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340366: Open source several AWT Dialog tests - Batch 3 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21218/head:pull/21218
$ git checkout pull/21218

Update a local copy of the PR:
$ git checkout pull/21218
$ git pull https://git.openjdk.org/jdk.git pull/21218/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21218

View PR using the GUI difftool:
$ git pr show -t 21218

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21218.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2024

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 27, 2024

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340366: Open source several AWT Dialog tests - Batch 3

Reviewed-by: prr, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 417 new commits pushed to the master branch:

  • 45a6359: 8341668: Shenandoah: assert(tail_bits < (idx_t)BitsPerWord) failed: precondition
  • d996ca8: 8341581: Optimize BytecodeHelpers validate slot
  • 4d50cbb: 8341278: Open source few TrayIcon tests - Set7
  • 23f3ca2: 8330206: Bump minimum boot jdk to JDK 23
  • fc7244d: 8340713: Open source DnD tests - Set5
  • f7bb647: 8341595: Clean up iteration of CEN headers in ZipFile.Source.initCEN
  • d0c5e4b: 8341373: Open source closed frame tests # 4
  • 3359518: 8341593: Problemlist java/foreign/TestUpcallStress.java in Xcomp mode
  • a2372c6: 8341238: G1: Refactor G1Policy to move collection set selection methods into G1CollectionSet
  • 4ba170c: 8341235: Improve default instruction frame title in PassFailJFrame
  • ... and 407 more: https://git.openjdk.org/jdk/compare/a18d9d84cd92b0b7e7c3c83efab1d81773e3a87c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 27, 2024
@openjdk
Copy link

openjdk bot commented Sep 27, 2024

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Sep 27, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 29, 2024
Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good.

@TejeshR13
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

Going to push as commit a7d2077.
Since your change was applied there have been 467 commits pushed to the master branch:

  • 2d8fcc4: 8340193: Open source several AWT Dialog tests - Batch 1
  • 6e01384: 8341136: Optimize StackMapGenerator::trimAndCompress
  • e9327b6: 8339205: Optimize StackMapGenerator
  • 1604255: 8341619: C2: remove unused StoreCM node
  • e7c5bf4: 8341722: Fix some warnings as errors when building on Linux with toolchain clang
  • 36fca5d: 8341882: [BACKOUT] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
  • 780de00: 8051591: Test javax/swing/JTabbedPane/8007563/Test8007563.java fails
  • 313f4a9: 8340809: Open source few more AWT PopupMenu tests
  • 9d621d3: 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
  • 475f8f9: 8341859: Optimize ClassFile Benchmark Write
  • ... and 457 more: https://git.openjdk.org/jdk/compare/a18d9d84cd92b0b7e7c3c83efab1d81773e3a87c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2024
@openjdk openjdk bot closed this Oct 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 10, 2024
@openjdk
Copy link

openjdk bot commented Oct 10, 2024

@TejeshR13 Pushed as commit a7d2077.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants