8341037: Use standard layouts in DefaultFrameIconTest.java and MenuCrash.java

[aivanov-jdk]

Now that standard window layouts are available as part of the PassFailJFrame framework, we can use them in tests.

Two tests from #21180, specifically test/jdk/java/awt/Frame/DefaultFrameIconTest.java and test/jdk/java/awt/Frame/MenuCrash.java, use two test windows. At this time, the tests implement positioning explicitly in the test. After #21207 is integrated, these two tests could be updated to use the standard layout. They would serve as sample usage of multi-window test UI.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341037: Use standard layouts in DefaultFrameIconTest.java and MenuCrash.java (Bug - P4)

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer) Review applies to 7769baa6
• Phil Race (@prrace - Reviewer) Review applies to 7769baa6

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21226/head:pull/21226
$ git checkout pull/21226

Update a local copy of the PR:
$ git checkout pull/21226
$ git pull https://git.openjdk.org/jdk.git pull/21226/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21226

View PR using the GUI difftool:
$ git pr show -t 21226

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21226.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into pr/21207 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341037: Use standard layouts in DefaultFrameIconTest.java and MenuCrash.java

Reviewed-by: azvegint, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full (6f05c37d)
• 01: Full - Incremental (7769baa6)
• 00: Full (7769baa6)

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8341037-stdLayouts-DefaultFrameIcon-MenuCrash
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

⚠️ @aivanov-jdk This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[aivanov-jdk]

/integrate

[openjdk]

Going to push as commit c43202b.
Since your change was applied there has been 1 commit pushed to the master branch:

• 76283dd: 8341246: Test com/sun/tools/attach/PermissionTest.java fails access denied after JDK-8327114

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit c43202b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.