Skip to content

Conversation

@lmesnik
Copy link
Member

@lmesnik lmesnik commented Sep 28, 2024

Test jdk/jfr/startupargs/TestStartDuration.java
checks duration, the time might be too small for stress options like Xcomp.
So it makes sense to mark it as flaglesss.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21237/head:pull/21237
$ git checkout pull/21237

Update a local copy of the PR:
$ git checkout pull/21237
$ git pull https://git.openjdk.org/jdk.git pull/21237/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21237

View PR using the GUI difftool:
$ git pr show -t 21237

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21237.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2024

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 28, 2024

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless

Reviewed-by: syan, egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1196 new commits pushed to the master branch:

  • 573bcb6: 8345664: Use simple parameter type names in @link and @see tags
  • 4966419: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714
  • 0e2a285: 8344833: CTW: Make failing on zero classes optional
  • f6021a9: 8344668: Unnecessary array allocations and copying in TextLine
  • 874d68a: 8343747: C2: TestReplicateAtConv.java crashes with -XX:MaxVectorSize=8
  • d9a2213: 8345299: C2: some nodes can still have incorrect control after do_range_check()
  • 2286fae: 8345159: RISCV: Fix -Wzero-as-null-pointer-constant warning in emit_static_call_stub
  • 8403285: 8268145: [macos] Rendering artifacts is seen when text inside the JTable with TableCellEditor having JTextfield
  • aa38284: 8345435: Eliminate tier1_compiler_not_xcomp group
  • 9284602: 8345628: [BACKOUT] JDK-8287122 Use gcc12 -ftrivial-auto-var-init=pattern in debug builds
  • ... and 1186 more: https://git.openjdk.org/jdk/compare/73ebb848fdb66861e912ea747c039ddd1f7a5f48...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 28, 2024
@openjdk
Copy link

openjdk bot commented Sep 28, 2024

@lmesnik The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Sep 28, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2024

@lmesnik This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@lmesnik
Copy link
Member Author

lmesnik commented Oct 26, 2024

/cc hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 26, 2024
@openjdk
Copy link

openjdk bot commented Oct 26, 2024

@lmesnik
The hotspot label was successfully added.

@sendaoYan
Copy link
Member

We observed the same failure by dragonwell17

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2024
@lmesnik
Copy link
Member Author

lmesnik commented Dec 6, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2024

Going to push as commit 470701f.
Since your change was applied there have been 1196 commits pushed to the master branch:

  • 573bcb6: 8345664: Use simple parameter type names in @link and @see tags
  • 4966419: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714
  • 0e2a285: 8344833: CTW: Make failing on zero classes optional
  • f6021a9: 8344668: Unnecessary array allocations and copying in TextLine
  • 874d68a: 8343747: C2: TestReplicateAtConv.java crashes with -XX:MaxVectorSize=8
  • d9a2213: 8345299: C2: some nodes can still have incorrect control after do_range_check()
  • 2286fae: 8345159: RISCV: Fix -Wzero-as-null-pointer-constant warning in emit_static_call_stub
  • 8403285: 8268145: [macos] Rendering artifacts is seen when text inside the JTable with TableCellEditor having JTextfield
  • aa38284: 8345435: Eliminate tier1_compiler_not_xcomp group
  • 9284602: 8345628: [BACKOUT] JDK-8287122 Use gcc12 -ftrivial-auto-var-init=pattern in debug builds
  • ... and 1186 more: https://git.openjdk.org/jdk/compare/73ebb848fdb66861e912ea747c039ddd1f7a5f48...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2024
@openjdk openjdk bot closed this Dec 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2024
@openjdk
Copy link

openjdk bot commented Dec 6, 2024

@lmesnik Pushed as commit 470701f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants