8258383: vmTestbase/gc/g1/unloading/tests/unloading_compilation_level[1,2,3] time out without TieredCompilation

[TobiHartmann]

The test gets stuck while waiting for a compilation to succeed, because the corresponding compilation level is not available since Tiered Compilation is disabled (or TieredStopAtLevel is set). The tests should not be executed without Tiered Compilation (or if the requested compilation level is not available) and also check the output of enqueueMethodForCompilation for sanity.

Thanks,
Tobias

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258383: vmTestbase/gc/g1/unloading/tests/unloading_compilation_level[1,2,3] time out without TieredCompilation

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2125/head:pull/2125
$ git checkout pull/2125

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c89cb5d)
• 00: Full (0a31cbd)

[vnkozlov]

I see such requires patter in other tests too.
But what will happen if server VM is built without C1 - no tiered?
Such tests may need additions requires vm.compiler1.enabled

Also when requested level 4 compilation (compilation_level4 tests) you don't need to force -XX:+TieredCompilation.

[TobiHartmann]

Thanks for the review Vladimir.

I see such requires patter in other tests too.
But what will happen if server VM is built without C1 - no tiered?
Such tests may need additions requires vm.compiler1.enabled

Yes, I've took that pattern from other tests. The problem with requires vm.compiler1.enabled is that the test will be skipped if -XX:-TieredCompilation is set (because then C1 is not available). Since this is a general problem that affects other tests as well, I think it should be addressed separately if necessary. What do you think?

Also when requested level 4 compilation (compilation_level4 tests) you don't need to force -XX:+TieredCompilation.

Right, I've updated the corresponding tests.

[vnkozlov]

Good.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258383: vmTestbase/gc/g1/unloading/tests/unloading_compilation_level[1,2,3] time out without TieredCompilation

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 5d8861b: 8259995: Missing comma to separate years in copyright header
• 5cfb36e: 8259036: Failed JfrVersionSystem invariant when VM built with -fno-elide-constructors
• c0e9c44: 8259962: Shenandoah: task queue statistics is inconsistent after JDK-8255019
• 82adfb3: 8134540: Much nearly duplicated code for PerfMemory support
• a9519c8: 8259924: GitHub actions fail on Linux x86_32 with "Could not configure libc6:i386"
• 139f5d3: 8259035: Comments for load order of hsdis should be updated
• bd81ccf: 8259957: Build failure without C1 Compiler after JDK-8258004
• dfee7b8: 8259511: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java failed with "RuntimeException: Test failed: 20 failure(s)"
• 14ce8f1: 8259870: zBarrier.inline.hpp should not include javaClasses.hpp
• a1a851b: Merge
• ... and 10 more: https://git.openjdk.java.net/jdk/compare/ff275b3764d0dd38051e83d5a395c6c4dff15009...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vnkozlov]

Thanks for the review Vladimir.

I see such requires patter in other tests too.
But what will happen if server VM is built without C1 - no tiered?
Such tests may need additions requires vm.compiler1.enabled

Yes, I've took that pattern from other tests. The problem with requires vm.compiler1.enabled is that the test will be skipped if -XX:-TieredCompilation is set (because then C1 is not available). Since this is a general problem that affects other tests as well, I think it should be addressed separately if necessary. What do you think?

Yes, you are right about switching off C1 with TieredCompilation flag. Current changes are fine.
I agree with addressing C1 absence from VM build in separate changes. I think we need additional requires feature to check if C1/C2 are included in VM build. vm.server is not enough.

[TobiHartmann]

Thanks for the review, Vladimir!

[TobiHartmann]

/integrate

[openjdk]

@TobiHartmann Since your change was applied there have been 26 commits pushed to the master branch:

• 9f21bb6: 8259983: do not use uninitialized expand_ms value in G1CollectedHeap::expand_heap_after_young_collection
• cf25383: Merge
• f7b96d3: 8259796: timed CompletableFuture.get may swallow InterruptedException
• a37cd5a: 8259859: Missing metaspace NMT memory tag
• 33dcc00: 8132984: incorrect type for Reference.discovered
• 3edf393: 8259978: PPC64 builds broken after JDK-8258004
• 5d8861b: 8259995: Missing comma to separate years in copyright header
• 5cfb36e: 8259036: Failed JfrVersionSystem invariant when VM built with -fno-elide-constructors
• c0e9c44: 8259962: Shenandoah: task queue statistics is inconsistent after JDK-8255019
• 82adfb3: 8134540: Much nearly duplicated code for PerfMemory support
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/ff275b3764d0dd38051e83d5a395c6c4dff15009...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7c32ffe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.