-
Notifications
You must be signed in to change notification settings - Fork 6k
8340907: Open source closed frame tests # 2 #21264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8340907: Open source closed frame tests # 2 #21264
Conversation
👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into |
@azvegint This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
*/ | ||
|
||
import javax.swing.BoxLayout; | ||
import javax.swing.JFrame; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azvegint Since it is an AWT test should we be using Frame instead of JFrame ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is not a big deal in this case.
/integrate |
Going to push as commit f2a767f.
Your commit was automatically rebased without conflicts. |
Few more tests to open source
Testing looks good.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21264/head:pull/21264
$ git checkout pull/21264
Update a local copy of the PR:
$ git checkout pull/21264
$ git pull https://git.openjdk.org/jdk.git pull/21264/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21264
View PR using the GUI difftool:
$ git pr show -t 21264
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21264.diff
Webrev
Link to Webrev Comment