-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8337493: [JVMCI] Number of libgraal threads might be too low #21279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back rmosaner! A progress list of the required criteria for merging this PR into |
|
@rmosaner This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
/integrate |
|
/sponsor |
|
Going to push as commit 7cc7c08.
Your commit was automatically rebased without conflicts. |
The
-XX:JVMCINativeLibraryThreadFractionflag defines the ratio between JVMCI threads and C1 threads.With a default value of 0.33 the number of JVMCI threads is significantly smaller than the number of C2 threads would be.
This can lead to unexpected warmup behavior with
-XX:+UseJVMCICompiler. This PR changes the default value of-XX:JVMCINativeLibraryThreadFractionto yield the same number of JVMCI threads as C2 threads.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21279/head:pull/21279$ git checkout pull/21279Update a local copy of the PR:
$ git checkout pull/21279$ git pull https://git.openjdk.org/jdk.git pull/21279/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21279View PR using the GUI difftool:
$ git pr show -t 21279Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21279.diff
Webrev
Link to Webrev Comment