Skip to content

Conversation

@rmosaner
Copy link
Contributor

@rmosaner rmosaner commented Oct 1, 2024

The -XX:JVMCINativeLibraryThreadFraction flag defines the ratio between JVMCI threads and C1 threads.
With a default value of 0.33 the number of JVMCI threads is significantly smaller than the number of C2 threads would be.

This can lead to unexpected warmup behavior with -XX:+UseJVMCICompiler. This PR changes the default value of -XX:JVMCINativeLibraryThreadFraction to yield the same number of JVMCI threads as C2 threads.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8337493: [JVMCI] Number of libgraal threads might be too low (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21279/head:pull/21279
$ git checkout pull/21279

Update a local copy of the PR:
$ git checkout pull/21279
$ git pull https://git.openjdk.org/jdk.git pull/21279/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21279

View PR using the GUI difftool:
$ git pr show -t 21279

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21279.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2024

👋 Welcome back rmosaner! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@rmosaner This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337493: [JVMCI] Number of libgraal threads might be too low

Reviewed-by: dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 2dc3b1a: 8341201: Broken link in AbstractAnnotationValueVisitor7 due to extra quotation mark
  • ad5ffcc: 8341168: Cleanup dead code after JDK-8322630

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@rmosaner The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Oct 1, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2024

Webrevs

Copy link
Member

@dougxc dougxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2024
@rmosaner
Copy link
Contributor Author

rmosaner commented Oct 1, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@rmosaner
Your change (at version 9e0a318) is now ready to be sponsored by a Committer.

@dougxc
Copy link
Member

dougxc commented Oct 1, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

Going to push as commit 7cc7c08.
Since your change was applied there have been 3 commits pushed to the master branch:

  • f7c7958: 8340420: ZGC: Should call vm_shutdown_during_initialization if initialization fails
  • 2dc3b1a: 8341201: Broken link in AbstractAnnotationValueVisitor7 due to extra quotation mark
  • ad5ffcc: 8341168: Cleanup dead code after JDK-8322630

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 1, 2024
@openjdk openjdk bot closed this Oct 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@dougxc @rmosaner Pushed as commit 7cc7c08.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants