8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos

[manukumarvs]

javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos.
This could be because of a synchronisation issue in the test.

Fix: I have refactored the test to have a CountDownLatch to monitor the ProgressMonitor and when it reaches 20%, it will be triggered. I have also removed the ProgressMonitor update logic execution from EDT as it would block the EDT sometimes. Also added a proper frame disposal mechanism.

Testing:
This is properly tested multiple times in all available platforms in mach5.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos (Bug - P4)

Reviewers

• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21293/head:pull/21293
$ git checkout pull/21293

Update a local copy of the PR:
$ git checkout pull/21293
$ git pull https://git.openjdk.org/jdk.git pull/21293/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21293

View PR using the GUI difftool:
$ git pr show -t 21293

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21293.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• bdfb41f: 8309841: Jarsigner should print a warning if an entry is removed
• 57c1db5: 8332697: ubsan: shenandoahSimpleBitMap.inline.hpp:68:23: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long int'
• dc0ce1b: 8341336: Fix -Wzero-as-null-pointer-constant warnings in PRODUCT-only code
• c43202b: 8341037: Use standard layouts in DefaultFrameIconTest.java and MenuCrash.java
• 76283dd: 8341246: Test com/sun/tools/attach/PermissionTest.java fails access denied after JDK-8327114
• 0bdfe88: 8328313: Archived module graph should allow identical --module-path to be specified during dump time and run time
• 9fc1c68: 8339850: Restore the interrupt status in FileSystemPreferences.lockFile()
• 5063494: 8340785: Update description of PassFailJFrame and samples
• 85f0442: 8317116: Provide layouts for multiple test UI in PassFailJFrame
• 49501fe: 8341412: Various test failures after JDK-8334305
• ... and 16 more: https://git.openjdk.org/jdk/compare/9a7817b1376d055c5a7c1005b275cc1f198e5364...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@manukumarvs The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (11ea52d8)
• 00: Full (bb6308e3)

[manukumarvs]

/integrate

[openjdk]

@manukumarvs
Your change (at version 11ea52d) is now ready to be sponsored by a Committer.

[prrace]

/sponsor

[openjdk]

Going to push as commit 6bc3971.
Since your change was applied there have been 46 commits pushed to the master branch:

• e89fd1d: 8341128: open source some 2d graphics tests
• 6f459af: 8340077: Open source few Checkbox tests - Set2
• b6e72ff: 8339403: sun.security.ssl.StatusResponseManager.get swallows interrupt status
• 013250e: 8340432: Open source some MenuBar tests - Set2
• de12fc7: 8339684: ResizeObserver callback interrupts smooth scrolling on Chrome
• ebb4759: 8340625: Open source additional Component tests (part 3)
• 3ee94e0: 8341282: (fs) Move creation time fallback logic to Java layer (Linux)
• f1ea57f: 8340229: Improve opening sentence of FileInputStream constructor specification
• 1202800: 8341006: Optimize StackMapGenerator detect frames
• eb93e69: 8339979: VirtualThreadSchedulerMXBeanTest.testReduceParallelism fails intermittently
• ... and 36 more: https://git.openjdk.org/jdk/compare/9a7817b1376d055c5a7c1005b275cc1f198e5364...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace @manukumarvs Pushed as commit 6bc3971.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.