Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253261: Disable CDS full module graph until JDK-8253081 is fixed #213

Closed

Conversation

iklam
Copy link
Member

@iklam iklam commented Sep 16, 2020

Please review this trivial patch.

JDK-8244778 (Archive full module graph in CDS) is causing failures in GC (JDK-8253081)

This patch disables the use of the CDS module graph at run time, which seems to avoid the GC problems. The module graph is still being archived into CDS, but that seems to be harmless.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253261: Disable CDS full module graph until JDK-8253081 is fixed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/213/head:pull/213
$ git checkout pull/213

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2020

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@iklam The following label will be automatically applied to this pull request: hotspot-runtime.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 16, 2020
@iklam iklam marked this pull request as ready for review September 16, 2020 20:49
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 16, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2020

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@iklam This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253261: Disable CDS full module graph until JDK-8253081 is fixed

Reviewed-by: ccheung
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 36 commits pushed to the master branch:

  • 1c84cfa: 8253130: bug7072653.java failed "Popup window height ... is wrong"
  • ce93cbc: 8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
  • d250f9e: 8253244: Shenandoah: cleanup includes in Shenandoah root processor files
  • d38c97d: 8253207: enable problemlists jcheck's check
  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
  • 1086713: 8253206: Enforce whitespace checking for additional source files
  • e2196f8: 8253162: Make frame::oops_do const
  • 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
  • c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/70cc7fc198a68345345e963a0252f0f3f9f1cf73...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 1c84cfa2364fa18fc028df89bdc4de207365784f.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 16, 2020
@iklam
Copy link
Member Author

iklam commented Sep 16, 2020

/integrate

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@iklam Since your change was applied there have been 36 commits pushed to the master branch:

  • 1c84cfa: 8253130: bug7072653.java failed "Popup window height ... is wrong"
  • ce93cbc: 8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
  • d250f9e: 8253244: Shenandoah: cleanup includes in Shenandoah root processor files
  • d38c97d: 8253207: enable problemlists jcheck's check
  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
  • 1086713: 8253206: Enforce whitespace checking for additional source files
  • e2196f8: 8253162: Make frame::oops_do const
  • 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
  • c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
  • ... and 26 more: https://git.openjdk.java.net/jdk/compare/70cc7fc198a68345345e963a0252f0f3f9f1cf73...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9a7dcdc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants