8341415: Optimize RawBytecodeHelper::next

[wenshao]

A small optimization to the RawBytecodeHelper::next method

• Remove len <= 0 once
• merge store opcode and isWide

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341415: Optimize RawBytecodeHelper::next (Sub-task - P4)

Reviewers

• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21300/head:pull/21300
$ git checkout pull/21300

Update a local copy of the PR:
$ git checkout pull/21300
$ git pull https://git.openjdk.org/jdk.git pull/21300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21300

View PR using the GUI difftool:
$ git pr show -t 21300

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21300.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back swen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wenshao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341415: Optimize RawBytecodeHelper::next

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• bdfb41f: 8309841: Jarsigner should print a warning if an entry is removed
• 57c1db5: 8332697: ubsan: shenandoahSimpleBitMap.inline.hpp:68:23: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long int'
• dc0ce1b: 8341336: Fix -Wzero-as-null-pointer-constant warnings in PRODUCT-only code
• c43202b: 8341037: Use standard layouts in DefaultFrameIconTest.java and MenuCrash.java
• 76283dd: 8341246: Test com/sun/tools/attach/PermissionTest.java fails access denied after JDK-8327114
• 0bdfe88: 8328313: Archived module graph should allow identical --module-path to be specified during dump time and run time
• 9fc1c68: 8339850: Restore the interrupt status in FileSystemPreferences.lockFile()
• 5063494: 8340785: Update description of PassFailJFrame and samples
• 85f0442: 8317116: Provide layouts for multiple test UI in PassFailJFrame
• 49501fe: 8341412: Various test failures after JDK-8334305
• ... and 9 more: https://git.openjdk.org/jdk/compare/39c17b392699007496816f788fca9fbe670dd6f8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@wenshao The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2b0f0663)

[liach]

This patch is neutral for startup benchmark. Good if it improves the repeated JMH benchmarks.

[wenshao]

/integrate

[openjdk]

Going to push as commit d7f32d8.
Since your change was applied there have been 26 commits pushed to the master branch:

• 6af1358: 8337753: Target class of upcall stub may be unloaded
• 19642bd: 8341148: Open source several Choice related tests
• 0b467e9: 8334060: Implementation of Late Barrier Expansion for G1
• c6e7e55: 8341091: CDS: Segmented roots array misses roots
• ff3e849: 8341239: Open source closed frame tests # 3
• 50ec169: 8341191: Open source few more AWT FileDialog tests
• 602408e: 8341177: Opensource few List and a Window test
• bdfb41f: 8309841: Jarsigner should print a warning if an entry is removed
• 57c1db5: 8332697: ubsan: shenandoahSimpleBitMap.inline.hpp:68:23: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long int'
• dc0ce1b: 8341336: Fix -Wzero-as-null-pointer-constant warnings in PRODUCT-only code
• ... and 16 more: https://git.openjdk.org/jdk/compare/39c17b392699007496816f788fca9fbe670dd6f8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wenshao Pushed as commit d7f32d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.