Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore #21305

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fguallini
Copy link
Member

@fguallini fguallini commented Oct 2, 2024

The test: sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java relies on the certutil.exe tool to import and delete certificates from a keystore. It was annotated with @ignore due to the uncertainty of certutil.exe being available on the instance where the test is executed.

Rather than ignoring the test entirely, this PR updates the logic to throw a SkippedException if the tool is not found, ensuring the test runs when possible, and gracefully skipped otherwise.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21305/head:pull/21305
$ git checkout pull/21305

Update a local copy of the PR:
$ git checkout pull/21305
$ git pull https://git.openjdk.org/jdk.git pull/21305/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21305

View PR using the GUI difftool:
$ git pr show -t 21305

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21305.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2024

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@fguallini The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Oct 2, 2024
@fguallini fguallini changed the title 8249831: test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore Oct 3, 2024
@openjdk openjdk bot changed the title 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore 8249831: test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore Oct 3, 2024
@fguallini fguallini changed the title 8249831: test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore Oct 3, 2024
@openjdk openjdk bot changed the title 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore 8249831: test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore Oct 3, 2024
@fguallini fguallini changed the title 8249831: test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore Oct 3, 2024
@fguallini fguallini marked this pull request as ready for review October 3, 2024 12:06
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

@fguallini This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2024

@fguallini This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Nov 29, 2024
@fguallini
Copy link
Member Author

/open

@openjdk openjdk bot reopened this Dec 3, 2024
@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@fguallini This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 31, 2024

@fguallini This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@fguallini
Copy link
Member Author

Review pending 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant