-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore #21305
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@fguallini The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@fguallini This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@fguallini This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
/open |
@fguallini This pull request is now open |
@fguallini This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Review pending 🙏 |
The test: sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java relies on the
certutil.exe
tool to import and delete certificates from a keystore. It was annotated with@ignore
due to the uncertainty ofcertutil.exe
being available on the instance where the test is executed.Rather than ignoring the test entirely, this PR updates the logic to throw a
SkippedException
if the tool is not found, ensuring the test runs when possible, and gracefully skipped otherwise.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21305/head:pull/21305
$ git checkout pull/21305
Update a local copy of the PR:
$ git checkout pull/21305
$ git pull https://git.openjdk.org/jdk.git pull/21305/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21305
View PR using the GUI difftool:
$ git pr show -t 21305
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21305.diff
Using Webrev
Link to Webrev Comment