-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8341412: Various test failures after JDK-8334305 #21307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back rsunderbabu! A progress list of the required criteria for merging this PR into |
|
@rsunderbabu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik, @dcubed-ojdk) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@rsunderbabu The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
lmesnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and trivial
dcubed-ojdk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up. I agree that this is trivial.
What testing has been run?
tier1,tier2,tier3 |
|
/integrate |
|
/sponsor |
|
@rsunderbabu |
|
@lmesnik @rsunderbabu Pushed as commit 49501fe. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
PrintStream passed in the constructor of nsk.share.Log was accidentally deleted while cleaning up verbose related code.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21307/head:pull/21307$ git checkout pull/21307Update a local copy of the PR:
$ git checkout pull/21307$ git pull https://git.openjdk.org/jdk.git pull/21307/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21307View PR using the GUI difftool:
$ git pr show -t 21307Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21307.diff
Webrev
Link to Webrev Comment