Skip to content

Conversation

@rsunderbabu
Copy link
Member

@rsunderbabu rsunderbabu commented Oct 2, 2024

PrintStream passed in the constructor of nsk.share.Log was accidentally deleted while cleaning up verbose related code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341412: Various test failures after JDK-8334305 (Bug - P1)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21307/head:pull/21307
$ git checkout pull/21307

Update a local copy of the PR:
$ git checkout pull/21307
$ git pull https://git.openjdk.org/jdk.git pull/21307/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21307

View PR using the GUI difftool:
$ git pr show -t 21307

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21307.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2024

👋 Welcome back rsunderbabu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@rsunderbabu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341412: Various test failures after JDK-8334305

Reviewed-by: lmesnik, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8838048: 8324259: Classes used by CDS at runtime should be archived

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik, @dcubed-ojdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 2, 2024
@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@rsunderbabu The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 2, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2024

Webrevs

Copy link
Member

@lmesnik lmesnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and trivial

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 2, 2024
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. I agree that this is trivial.

What testing has been run?

@rsunderbabu
Copy link
Member Author

Thumbs up. I agree that this is trivial.

What testing has been run?

tier1,tier2,tier3
mainly looking for open/test/hotspot/jtreg/:vmTestbase_vm_mlvm runs in tier2 and tier3

@rsunderbabu
Copy link
Member Author

/integrate

@lmesnik
Copy link
Member

lmesnik commented Oct 2, 2024

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 2, 2024
@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@rsunderbabu
Your change (at version b47dc66) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

Going to push as commit 49501fe.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 8838048: 8324259: Classes used by CDS at runtime should be archived

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 2, 2024
@openjdk openjdk bot closed this Oct 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 2, 2024
@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@lmesnik @rsunderbabu Pushed as commit 49501fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rsunderbabu rsunderbabu deleted the 8341412 branch October 11, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants