8341424: GHA: Collect hs_errs from build time failures

[shipilev]

GHA conveniently collects hs_errs from the test job runs. However, when we have a failure during the build, e.g. javac, CDS, jmod, jlink crashes the VM, we don't have these automatically collected. This is annoying when VM crashes on a particular platform, and not on others.

We can add the hooks for these as well. This PR adapts what we already have for test result collectors here: https://github.com/openjdk/jdk/blob/master/.github/scripts/gen-test-results.sh

I added a deliberate failure point in CDS to demonstrate how it would look like in test summary.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341424: GHA: Collect hs_errs from build time failures (Enhancement - P4)

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21308/head:pull/21308
$ git checkout pull/21308

Update a local copy of the PR:
$ git checkout pull/21308
$ git pull https://git.openjdk.org/jdk.git pull/21308/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21308

View PR using the GUI difftool:
$ git pr show -t 21308

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21308.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341424: GHA: Collect hs_errs from build time failures

Reviewed-by: ihse, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• d936556: 8341633: StatSampler::assert_system_property: Print the keys and values of the assert
• 3fba170: 8340786: Introduce Predicate classes with predicate iterators and visitors for simplified walking
• 047c2d7: 8341141: Optimize DirectCodeBuilder
• d636e0d: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
• d3f3c6a: 8330157: C2: Add a stress flag for bailouts
• d809bc0: 8341658: RISC-V: Test DateFormatProviderTest.java run timeouted
• de90204: 8341588: Remove CollectionUsageThreshold.java from ProblemList-Xcomp for debugging
• f276f58: 8341803: ProblemList containers/docker/TestJcmdWithSideCar.java on linux-x64
• 7eab0a5: 8337066: Repeated call of StringBuffer.reverse with double byte string returns wrong result
• 62acc9c: 8341548: More concise use of classfile API
• ... and 4 more: https://git.openjdk.org/jdk/compare/580eb62dc097efeb51c76b095c1404106859b673...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• build
• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (cc1770f6)
• 02: Full - Incremental (1ae90b20)
• 01: Full - Incremental (99529399)
• 00: Full (db5b13c0)

[shipilev]

/label remove hotspot-runtime

[openjdk]

@shipilev
The hotspot-runtime label was successfully removed.

[magicus]

This looks really nice! Thanks for implementing this, and for cleaning it up.

[TheShermanTanker]

> Yank the cord
> Gaaaaaaah

Story of my life while working on hard to fix problems

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit 3ab519f.
Since your change was applied there have been 22 commits pushed to the master branch:

• a24525b: 8339320: Optimize ClassFile Utf8EntryImpl#inflate
• fcc9c8d: 8341854: Incorrect clearing of ZF in fast_unlock_lightweight on x86
• 38c1d65: 8337980: Javac allows invocation of an inherited instance method from a static method
• 950e3a7: 8341625: Improve ZipFile validation of the END header
• e704c05: 8340547: Starting many threads can delay safepoints
• c30ad01: 8325495: C2: implement optimization for series of Add of unique value
• ff2f39f: 8340214: C2 compilation asserts with "no node with a side effect" in PhaseIdealLoop::try_sink_out_of_loop
• ecc77a5: 8336702: C2 compilation fails with "all memory state should have been processed" assert
• d936556: 8341633: StatSampler::assert_system_property: Print the keys and values of the assert
• 3fba170: 8340786: Introduce Predicate classes with predicate iterators and visitors for simplified walking
• ... and 12 more: https://git.openjdk.org/jdk/compare/580eb62dc097efeb51c76b095c1404106859b673...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 3ab519f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.