Skip to content

8341239: Open source closed frame tests # 3#21309

Closed
azvegint wants to merge 1 commit intoopenjdk:masterfrom
azvegint:testsprint_2024_09/8341239_frame_batch3
Closed

8341239: Open source closed frame tests # 3#21309
azvegint wants to merge 1 commit intoopenjdk:masterfrom
azvegint:testsprint_2024_09/8341239_frame_batch3

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented Oct 2, 2024

Few more tests to open source:

  • test/jdk/java/awt/Frame/FrameMenuPackTest.java
  • test/jdk/java/awt/Frame/FrameResizeTest/FrameResizeTest_3.java
  • test/jdk/java/awt/Frame/FrameResizeTest/FrameResizeTest_4.java
  • test/jdk/java/awt/Frame/FrameResizeTest/FrameResizeTest_5.java

Testing looks good.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341239: Open source closed frame tests # 3 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21309/head:pull/21309
$ git checkout pull/21309

Update a local copy of the PR:
$ git checkout pull/21309
$ git pull https://git.openjdk.org/jdk.git pull/21309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21309

View PR using the GUI difftool:
$ git pr show -t 21309

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21309.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2024

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341239: Open source closed frame tests # 3

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • c43202b: 8341037: Use standard layouts in DefaultFrameIconTest.java and MenuCrash.java
  • 76283dd: 8341246: Test com/sun/tools/attach/PermissionTest.java fails access denied after JDK-8327114
  • 0bdfe88: 8328313: Archived module graph should allow identical --module-path to be specified during dump time and run time
  • 9fc1c68: 8339850: Restore the interrupt status in FileSystemPreferences.lockFile()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 2, 2024
@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 2, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 2, 2024
@azvegint
Copy link
Member Author

azvegint commented Oct 3, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

Going to push as commit ff3e849.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 50ec169: 8341191: Open source few more AWT FileDialog tests
  • 602408e: 8341177: Opensource few List and a Window test
  • bdfb41f: 8309841: Jarsigner should print a warning if an entry is removed
  • 57c1db5: 8332697: ubsan: shenandoahSimpleBitMap.inline.hpp:68:23: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long int'
  • dc0ce1b: 8341336: Fix -Wzero-as-null-pointer-constant warnings in PRODUCT-only code
  • c43202b: 8341037: Use standard layouts in DefaultFrameIconTest.java and MenuCrash.java
  • 76283dd: 8341246: Test com/sun/tools/attach/PermissionTest.java fails access denied after JDK-8327114
  • 0bdfe88: 8328313: Archived module graph should allow identical --module-path to be specified during dump time and run time
  • 9fc1c68: 8339850: Restore the interrupt status in FileSystemPreferences.lockFile()

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 3, 2024
@openjdk openjdk bot closed this Oct 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2024
@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@azvegint Pushed as commit ff3e849.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants