8340799: Add border inside instruction frame in PassFailJFrame

[aivanov-jdk]

This changeset unifies borders used inside the PassFailJFrame framework and adds missing borders.

I started it in for JDK-8340306. That changeset handled only the instructions.

This changeset add a border around the entire contents of the instruction frame, adds a border to the log area as well as to the failure reason dialog. The result looks more pleasing and consistent.

I chose the gap of 4 because it plays nicely with fractional scales: 4 × 1.25 = 5 — no fractional pixels.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340799: Add border inside instruction frame in PassFailJFrame (Enhancement - P4)

Reviewers

• Phil Race (@prrace - Reviewer)
• Damon Nguyen (@DamonGuy - Committer)
• @abdelhak-zaaim (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21327/head:pull/21327
$ git checkout pull/21327

Update a local copy of the PR:
$ git checkout pull/21327
$ git pull https://git.openjdk.org/jdk.git pull/21327/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21327

View PR using the GUI difftool:
$ git pr show -t 21327

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21327.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340799: Add border inside instruction frame in PassFailJFrame

Reviewed-by: prr, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• 50426b3: 8337713: RISC-V: fix typos in macroAssembler_riscv.cpp
• 260d465: 8340572: ConcurrentModificationException when sorting ArrayList sublists
• 9a25f82: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
• df763cd: 8341558: [AIX] build broken after 8341413
• 1c3e56c: 8341512: Optimize StackMapGenerator::processInvokeInstructions
• f8db3a8: 8341510: Optimize StackMapGenerator::processFieldInstructions
• b42fbf4: 8339699: Optimize DataOutputStream writeUTF
• 5592894: 8340417: Open source some MenuBar tests - Set1
• bade041: 8341554: Shenandoah: Missing heap lock when updating usage for soft ref policy
• 85e0e64: 8341443: [macos] AppContentTest and SigningOptionsTest failed due to "codesign" does not fails with "--app-content" on macOS 15
• ... and 43 more: https://git.openjdk.org/jdk/compare/ff3e849b8a1de3741dcd728636e1a804996f96fe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[aivanov-jdk]

I accidentally committed these three lines in for JDK-8340785 and I didn't notice it.

This three-line snippet was completely unrelated to updating description of the PassFailJFrame class and samples.

[mlbridge]

Webrevs

• 00: Full (5c0064c4)

[aivanov-jdk]

A couple of screenshots for comparison.

Before:

After:

[DamonGuy]

Changes look good! The "after" screenshot does look better with a gap.

[aivanov-jdk]

/integrate

[openjdk]

Going to push as commit 520060f.
Since your change was applied there have been 59 commits pushed to the master branch:

• 2897797: 8340880: RISC-V: add t3-t6 alias into assemler_riscv.hpp
• 747a3fa: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
• 81ebbb2: 8341525: G1: use bit clearing to remove tightly-coupled initialization store pre-barriers
• 92186a2: 8341612: [BACKOUT] 8338442: AArch64: Clean up IndOffXX type and let legitimize_address() fix out-of-range operands
• 6600161: 8338379: Accesses to class init state should be properly synchronized
• 20f36c6: 8339329: ConstantPoolBuilder#constantValueEntry method doc typo and clarifications
• 50426b3: 8337713: RISC-V: fix typos in macroAssembler_riscv.cpp
• 260d465: 8340572: ConcurrentModificationException when sorting ArrayList sublists
• 9a25f82: 8339386: Assertion on AIX - original PC must be in the main code section of the compiled method
• df763cd: 8341558: [AIX] build broken after 8341413
• ... and 49 more: https://git.openjdk.org/jdk/compare/ff3e849b8a1de3741dcd728636e1a804996f96fe...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit 520060f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.