Skip to content

8341258: Open source few various AWT tests - Set1#21338

Closed
DamonGuy wants to merge 1 commit intoopenjdk:masterfrom
DamonGuy:8341258/set7Open
Closed

8341258: Open source few various AWT tests - Set1#21338
DamonGuy wants to merge 1 commit intoopenjdk:masterfrom
DamonGuy:8341258/set7Open

Conversation

@DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Oct 3, 2024

Following tests are added as part of this PR:

./java/awt/GradientPaint/JerkyGradient.java - MANUAL
./java/awt/GradientPaint/ShearTest.java - MANUAL
./java/awt/CardLayout/RemoveComponentTest/RemoveComponentTest.java - MANUAL


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341258: Open source few various AWT tests - Set1 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21338/head:pull/21338
$ git checkout pull/21338

Update a local copy of the PR:
$ git checkout pull/21338
$ git pull https://git.openjdk.org/jdk.git pull/21338/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21338

View PR using the GUI difftool:
$ git pr show -t 21338

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21338.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2024

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341258: Open source few various AWT tests - Set1

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 711 new commits pushed to the master branch:

  • 10402b4: 8341489: ProblemList runtime/cds/appcds/DumpRuntimeClassesTest.java in Xcomp mode
  • 6bc3971: 8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos
  • e89fd1d: 8341128: open source some 2d graphics tests
  • 6f459af: 8340077: Open source few Checkbox tests - Set2
  • b6e72ff: 8339403: sun.security.ssl.StatusResponseManager.get swallows interrupt status
  • 013250e: 8340432: Open source some MenuBar tests - Set2
  • de12fc7: 8339684: ResizeObserver callback interrupts smooth scrolling on Chrome
  • ebb4759: 8340625: Open source additional Component tests (part 3)
  • 3ee94e0: 8341282: (fs) Move creation time fallback logic to Java layer (Linux)
  • f1ea57f: 8340229: Improve opening sentence of FileInputStream constructor specification
  • ... and 701 more: https://git.openjdk.org/jdk/compare/3f8b3e55276336cbb814d3b746d4337678389969...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2024
@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@DamonGuy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 3, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 4, 2024
@DamonGuy
Copy link
Contributor Author

DamonGuy commented Oct 4, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2024

Going to push as commit 86e3d52.
Since your change was applied there have been 731 commits pushed to the master branch:

  • 92cb633: 8340967: Open source few Cursor tests - Set2
  • 3d38cd9: 8340966: Open source few Checkbox and Cursor tests - Set1
  • 7e3978e: 8340164: Open source few Component tests - Set1
  • c8e70df: 8341162: Open source some of the AWT window test
  • 2e5b420: 8340326: Remove references to Applet in core-libs/security tests
  • f5f0852: 8341379: Shenandoah: Improve lock contention during cleanup
  • 04c9c5f: 8341111: open source several AWT tests including menu shortcut tests
  • 0dd4997: 8340555: Open source DnD tests - Set4
  • beb2a51: 8341377: Update VMProps.isCDSRuntimeOptionsCompatible to include Parallel and Serial GC
  • 42f3255: 8341053: Two CDS tests fail again with -UseCompressedOops and UseSerialGC/UseParallelGC
  • ... and 721 more: https://git.openjdk.org/jdk/compare/3f8b3e55276336cbb814d3b746d4337678389969...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2024
@openjdk openjdk bot closed this Oct 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2024
@openjdk
Copy link

openjdk bot commented Oct 4, 2024

@DamonGuy Pushed as commit 86e3d52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants