Skip to content

JDK-8340713 : Open source DnD tests - Set5 #21340

Closed
honkar-jdk wants to merge 5 commits intoopenjdk:masterfrom
honkar-jdk:DnDSet5
Closed

JDK-8340713 : Open source DnD tests - Set5 #21340
honkar-jdk wants to merge 5 commits intoopenjdk:masterfrom
honkar-jdk:DnDSet5

Conversation

@honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Oct 3, 2024

Following tests are open-sourced:

  1. /java/awt/dnd/DragExitBeforeDropTest.java - Automated, Problemlisted on macOS
  2. /java/awt/dnd/DragThresholdTest.java - Automated, Problemlisted on macOS
  3. /java/awt/dnd/WinMoveFileToShellTest.java - Manual, Windows only test, Problemlisted

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21340/head:pull/21340
$ git checkout pull/21340

Update a local copy of the PR:
$ git checkout pull/21340
$ git pull https://git.openjdk.org/jdk.git pull/21340/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21340

View PR using the GUI difftool:
$ git pr show -t 21340

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21340.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2024

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340713: Open source DnD tests - Set5

Reviewed-by: azvegint, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2024
@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 3, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 4, 2024
Copy link

@abdelhak-zaaim abdelhak-zaaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 7, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2024
@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 7, 2024

Going to push as commit fc7244d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 7, 2024
@openjdk openjdk bot closed this Oct 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2024
@openjdk
Copy link

openjdk bot commented Oct 7, 2024

@honkar-jdk Pushed as commit fc7244d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants