Skip to content

8341541: Wrong anchor in wrapper classes links #21361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hns
Copy link
Member

@hns hns commented Oct 4, 2024

Please review a doc change to fix the target anchor for the "wrapper class" links added in #21215.

In addition to changing the anchor to "wrapperClass" (singular) I also moved the id attribute to the <p> tag so that browser view is positioned over the whole paragraph instead of just the term "wrapper classes".


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341541: Wrong anchor in wrapper classes links (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21361/head:pull/21361
$ git checkout pull/21361

Update a local copy of the PR:
$ git checkout pull/21361
$ git pull https://git.openjdk.org/jdk.git pull/21361/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21361

View PR using the GUI difftool:
$ git pr show -t 21361

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21361.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2024

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 4, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8341541: Wrong anchor in wrapper classes links 8341541: Wrong anchor in wrapper classes links Oct 4, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 4, 2024
@openjdk
Copy link

openjdk bot commented Oct 4, 2024

@hns The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 4, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 4, 2024

Webrevs

Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this site

* java.lang##wrapperClasses wrapper classes} have an

to use wrapperClass instead of wrapperClasses.

@jddarcy
Copy link
Member

jddarcy commented Oct 4, 2024

Note only one of this PR and https://git.openjdk.org/jdk/pull/21360 should get pushed.

@hns hns closed this Oct 4, 2024
@hns
Copy link
Member Author

hns commented Oct 4, 2024

@jddarcy I closed this and approved yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants