JDK-8341278 : Open source few TrayIcon tests - Set7 by honkar-jdk · Pull Request #21365 · openjdk/jdk

honkar-jdk · 2024-10-04T22:47:49Z

The following tests are open-sourced. All are manual tests

test/jdk/java/awt/TrayIcon/ClearPrevImageTest.java
test/jdk/java/awt/TrayIcon/FocusLostAfterTrayTest.java
test/jdk/java/awt/TrayIcon/MouseMoveTest.java - problemlisted on linux
test/jdk/java/awt/TrayIcon/RemoveSystemTrayTest.java
test/jdk/java/awt/TrayIcon/TrayIconKeySelectTest.java - Windows only test and problemlisted on windows as the keyboard actions for trayicon don't work.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8341278: Open source few TrayIcon tests - Set7 (Bug - P4)

Reviewers

Alexander Zvegintsev (@azvegint - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21365/head:pull/21365
$ git checkout pull/21365

Update a local copy of the PR:
$ git checkout pull/21365
$ git pull https://git.openjdk.org/jdk.git pull/21365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21365

View PR using the GUI difftool:
$ git pr show -t 21365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21365.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-10-04T22:48:48Z

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-10-04T22:49:51Z

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341278: Open source few TrayIcon tests - Set7

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

fc7244d: 8340713: Open source DnD tests - Set5
f7bb647: 8341595: Clean up iteration of CEN headers in ZipFile.Source.initCEN
d0c5e4b: 8341373: Open source closed frame tests # 4
3359518: 8341593: Problemlist java/foreign/TestUpcallStress.java in Xcomp mode
a2372c6: 8341238: G1: Refactor G1Policy to move collection set selection methods into G1CollectionSet
4ba170c: 8341235: Improve default instruction frame title in PassFailJFrame
520060f: 8340799: Add border inside instruction frame in PassFailJFrame
2897797: 8340880: RISC-V: add t3-t6 alias into assemler_riscv.hpp
747a3fa: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
81ebbb2: 8341525: G1: use bit clearing to remove tightly-coupled initialization store pre-barriers
... and 14 more: https://git.openjdk.org/jdk/compare/a3e23572d5e879bd1c3b1755cf7be4601d03b62e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-10-04T22:51:05Z

@honkar-jdk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-10-04T22:54:01Z

Webrevs

01: Full - Incremental (86904e45)
00: Full (a4bc1160)

honkar-jdk · 2024-10-04T23:02:07Z

test/jdk/java/awt/TrayIcon/RemoveSystemTrayTest.java

+                   then press FAIL else goto next step.
+                4) Press button 'Show message'.
+                5) If you see the tray icon message then press FAIL else press PASS.
+                """;


This test was originally created for Solaris issue.

On macOS and Windows I was unable to remove the "System Tray" although there are options like pause notifications and hide trayicons, but in both cases with tray icon showing as well as hidden I wasn't able to see TrayIco msg.

On Ubuntu I'm unable to remove the System Tray but used the Do Not Disturb option to pause any notifications but in both cases the TrayIcon msg is displayed.

Is this test relevant to be retained or am I missing something while testing because I didn't find any options to remove the SystemTray on macOS, Windows & Ubuntu?

It's possible on Ubuntu, but not out of the box, it requires disabling the Ubuntu AppIndicators Gnome Shell extension.
AFAIK to disable extensions you need to install additional software(or perform some command in the terminal), so I suggest just not adding this test.

Thank you for clarifying @azvegint. Deleted the test.
When I checked there were few suggestion online about additional installations required (as you mentioned above) for the removal of SystemTray and it didn't seem to be straight-forward (like enabling/disabling in Settings) hence wanted to clarify before deleting this test.

honkar-jdk · 2024-10-07T21:27:45Z

/integrate

openjdk · 2024-10-07T21:29:23Z

Going to push as commit 4d50cbb.
Since your change was applied there have been 25 commits pushed to the master branch:

23f3ca2: 8330206: Bump minimum boot jdk to JDK 23
fc7244d: 8340713: Open source DnD tests - Set5
f7bb647: 8341595: Clean up iteration of CEN headers in ZipFile.Source.initCEN
d0c5e4b: 8341373: Open source closed frame tests # 4
3359518: 8341593: Problemlist java/foreign/TestUpcallStress.java in Xcomp mode
a2372c6: 8341238: G1: Refactor G1Policy to move collection set selection methods into G1CollectionSet
4ba170c: 8341235: Improve default instruction frame title in PassFailJFrame
520060f: 8340799: Add border inside instruction frame in PassFailJFrame
2897797: 8340880: RISC-V: add t3-t6 alias into assemler_riscv.hpp
747a3fa: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
... and 15 more: https://git.openjdk.org/jdk/compare/a3e23572d5e879bd1c3b1755cf7be4601d03b62e...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-10-07T21:29:30Z

@honkar-jdk Pushed as commit 4d50cbb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

honkar-jdk added 2 commits October 4, 2024 15:40

tray icon tests

a6274ea

updated lib path

a4bc116

openjdk bot added the rfr Pull request is ready for review label Oct 4, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Oct 4, 2024

honkar-jdk commented Oct 4, 2024

View reviewed changes

azvegint approved these changes Oct 7, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2024

deleted RemoveSystemTrayTest

86904e4

openjdk bot removed the ready Pull request is ready to be integrated label Oct 7, 2024

azvegint approved these changes Oct 7, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2024

openjdk bot added the integrated Pull request has been integrated label Oct 7, 2024

openjdk bot closed this Oct 7, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK-8341278 : Open source few TrayIcon tests - Set7 #21365

JDK-8341278 : Open source few TrayIcon tests - Set7 #21365
honkar-jdk wants to merge 3 commits intoopenjdk:masterfrom
honkar-jdk:trayIconSet7

honkar-jdk commented Oct 4, 2024 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Oct 4, 2024

Uh oh!

openjdk bot commented Oct 4, 2024 •

edited

Loading

Uh oh!

openjdk bot commented Oct 4, 2024

Uh oh!

mlbridge bot commented Oct 4, 2024 •

edited

Loading

Uh oh!

honkar-jdk Oct 4, 2024

Uh oh!

azvegint Oct 7, 2024 •

edited

Loading

Uh oh!

honkar-jdk Oct 7, 2024 •

edited

Loading

Uh oh!

honkar-jdk commented Oct 7, 2024

Uh oh!

openjdk bot commented Oct 7, 2024

Uh oh!

openjdk bot commented Oct 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

honkar-jdk commented Oct 4, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Oct 4, 2024

Uh oh!

openjdk bot commented Oct 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 4, 2024

Uh oh!

mlbridge bot commented Oct 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

honkar-jdk Oct 4, 2024

Choose a reason for hiding this comment

Uh oh!

azvegint Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

honkar-jdk Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

honkar-jdk commented Oct 7, 2024

Uh oh!

openjdk bot commented Oct 7, 2024

Uh oh!

openjdk bot commented Oct 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

honkar-jdk commented Oct 4, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Oct 4, 2024 •

edited

Loading

mlbridge bot commented Oct 4, 2024 •

edited

Loading

azvegint Oct 7, 2024 •

edited

Loading

honkar-jdk Oct 7, 2024 •

edited

Loading