Skip to content

JDK-8341378 : Open source few TrayIcon tests - Set8 #21366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Oct 4, 2024

Open sourced java/awt/TrayIcon/TrayIconTest.java - Manual test
Problemlisted on all platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341378: Open source few TrayIcon tests - Set8 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21366/head:pull/21366
$ git checkout pull/21366

Update a local copy of the PR:
$ git checkout pull/21366
$ git pull https://git.openjdk.org/jdk.git pull/21366/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21366

View PR using the GUI difftool:
$ git pr show -t 21366

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21366.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2024

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 4, 2024

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341378: Open source few TrayIcon tests - Set8

Reviewed-by: azvegint, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 6546353: 8340203: Link color is hard to distinguish from text color in API documentation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 4, 2024
@openjdk
Copy link

openjdk bot commented Oct 4, 2024

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 4, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 4, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2024
Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks like it was moved over and problem-listed correctly.

@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 8, 2024
@openjdk
Copy link

openjdk bot commented Oct 8, 2024

@honkar-jdk This pull request has not yet been marked as ready for integration.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 8, 2024
@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 8, 2024

Going to push as commit b9db74a.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 6546353: 8340203: Link color is hard to distinguish from text color in API documentation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 8, 2024
@openjdk openjdk bot closed this Oct 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 8, 2024
@openjdk
Copy link

openjdk bot commented Oct 8, 2024

@honkar-jdk Pushed as commit b9db74a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Oct 10, 2024

Mailing list message from Davide Perini on client-libs-dev:

In the mean time tray icon broke on Windows 11 24H2.

https://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8341173

If Oracle needs a three mouse button I can source it.
Just to answer the comment on the bug report that seems a bit weird.

Kind regards,
Davide

On 2024-10-08 18:37, Harshitha Onkar wrote:

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20241010/d306be08/attachment-0001.htm>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants