8341447: Open source closed frame tests # 5 by azvegint · Pull Request #21372 · openjdk/jdk

azvegint · 2024-10-05T21:13:36Z

More tests to open source:

java/awt/Frame/FocusTest.java - in the problem list on macos
java/awt/Frame/InitialIconifiedTest.java - added undecorated case, and improved failure detection for macos

Testing looks good.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8341447: Open source closed frame tests # 5 (Bug - P4)

Reviewers

Harshitha Onkar (@honkar-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21372/head:pull/21372
$ git checkout pull/21372

Update a local copy of the PR:
$ git checkout pull/21372
$ git pull https://git.openjdk.org/jdk.git pull/21372/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21372

View PR using the GUI difftool:
$ git pr show -t 21372

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21372.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-10-05T21:14:28Z

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-10-05T21:14:56Z

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341447: Open source closed frame tests # 5

Reviewed-by: honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

580eb62: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF
4a12f5b: 8341643: G1: Merged cards counter skewed by merge cards cache
6e48618: 8341644: Compile error in cgroup coding when using toolchain clang
7a1e832: 8336843: Deprecate java.util.zip.ZipError for removal
f62dba3: 8341597: ZipFileInflaterInputStream input buffer size uses uncompressed size
59ac703: 8339220: [s390x] TestIfMinMax.java failure
ffb60e5: 8341594: Use Unsafe to coalesce reads in java.util.zip.ZipUtils
57c859e: 8339836: Open source several AWT Mouse tests - Batch 1
b6a4047: 8339982: Open source several AWT Mouse tests - Batch 2
45a6359: 8341668: Shenandoah: assert(tail_bits < (idx_t)BitsPerWord) failed: precondition
... and 18 more: https://git.openjdk.org/jdk/compare/9a25f822fb2529c1cae3ae909761381789d7b7b1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-10-05T21:15:59Z

@azvegint The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-10-05T21:19:12Z

Webrevs

01: Full - Incremental (32aa7ff6)
00: Full (a8501024)

honkar-jdk

LGTM other than the minor comments

honkar-jdk · 2024-10-07T22:14:35Z

test/jdk/java/awt/Frame/InitialIconifiedTest.java

+        // robot.waitForIdle();
+        // robot.delay(500);


Tested on macOS and windows.
The test works on macOS with the work-around (extra delay) as described in the note.

honkar-jdk · 2024-10-07T22:15:13Z

test/jdk/java/awt/Frame/InitialIconifiedTest.java

            });
        }
+
+        if (!FAILURES.toString().isBlank()) {


Suggested change

if (!FAILURES.toString().isBlank()) {

if (!FAILURES.isEmpty()) {

honkar-jdk · 2024-10-07T22:15:37Z

test/jdk/java/awt/Frame/FocusTest.java

+              (You would click on the caption bar of another window,
+              and then on the caption bar of the FocusTest Frame.)
+
+              If the focus rectangle again appears, the test passes.


Suggested change

If the focus rectangle again appears, the test passes.

If the focus rectangle appears again, the test passes.

azvegint · 2024-10-08T17:36:03Z

/integrate

openjdk · 2024-10-08T17:37:50Z

Going to push as commit 966eb72.
Since your change was applied there have been 30 commits pushed to the master branch:

b9db74a: 8341378: Open source few TrayIcon tests - Set8
6546353: 8340203: Link color is hard to distinguish from text color in API documentation
580eb62: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF
4a12f5b: 8341643: G1: Merged cards counter skewed by merge cards cache
6e48618: 8341644: Compile error in cgroup coding when using toolchain clang
7a1e832: 8336843: Deprecate java.util.zip.ZipError for removal
f62dba3: 8341597: ZipFileInflaterInputStream input buffer size uses uncompressed size
59ac703: 8339220: [s390x] TestIfMinMax.java failure
ffb60e5: 8341594: Use Unsafe to coalesce reads in java.util.zip.ZipUtils
57c859e: 8339836: Open source several AWT Mouse tests - Batch 1
... and 20 more: https://git.openjdk.org/jdk/compare/9a25f822fb2529c1cae3ae909761381789d7b7b1...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-10-08T17:37:55Z

@azvegint Pushed as commit 966eb72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

azvegint added 2 commits October 5, 2024 23:01

8341447: Open source closed frame tests # 5

689b181

fix path in ProblemList.txt

a850102

openjdk bot added the rfr Pull request is ready for review label Oct 5, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Oct 5, 2024

honkar-jdk approved these changes Oct 7, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2024

review comments

32aa7ff

openjdk bot removed the ready Pull request is ready to be integrated label Oct 8, 2024

honkar-jdk approved these changes Oct 8, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 8, 2024

openjdk bot added the integrated Pull request has been integrated label Oct 8, 2024

openjdk bot closed this Oct 8, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8341447: Open source closed frame tests # 5#21372

8341447: Open source closed frame tests # 5#21372
azvegint wants to merge 3 commits intoopenjdk:masterfrom
azvegint:testsprint_2024_09/8341447_frame_batch5

azvegint commented Oct 5, 2024 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Oct 5, 2024

Uh oh!

openjdk bot commented Oct 5, 2024 •

edited

Loading

Uh oh!

openjdk bot commented Oct 5, 2024

Uh oh!

mlbridge bot commented Oct 5, 2024 •

edited

Loading

Uh oh!

honkar-jdk left a comment

Uh oh!

honkar-jdk Oct 7, 2024 •

edited

Loading

Uh oh!

honkar-jdk Oct 7, 2024

Uh oh!

honkar-jdk Oct 7, 2024

Uh oh!

azvegint Oct 8, 2024

Uh oh!

azvegint commented Oct 8, 2024

Uh oh!

openjdk bot commented Oct 8, 2024

Uh oh!

openjdk bot commented Oct 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

	if (!FAILURES.toString().isBlank()) {
	if (!FAILURES.isEmpty()) {

	If the focus rectangle again appears, the test passes.
	If the focus rectangle appears again, the test passes.

Conversation

azvegint commented Oct 5, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Oct 5, 2024

Uh oh!

openjdk bot commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 5, 2024

Uh oh!

mlbridge bot commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

honkar-jdk left a comment

Choose a reason for hiding this comment

Uh oh!

honkar-jdk Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

honkar-jdk Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

honkar-jdk Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

azvegint Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

azvegint commented Oct 8, 2024

Uh oh!

openjdk bot commented Oct 8, 2024

Uh oh!

openjdk bot commented Oct 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

azvegint commented Oct 5, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Oct 5, 2024 •

edited

Loading

mlbridge bot commented Oct 5, 2024 •

edited

Loading

honkar-jdk Oct 7, 2024 •

edited

Loading