Skip to content

8341637: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)#21388

Closed
dfuch wants to merge 2 commits intoopenjdk:masterfrom
dfuch:UdpSocket-8341637
Closed

8341637: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)#21388
dfuch wants to merge 2 commits intoopenjdk:masterfrom
dfuch:UdpSocket-8341637

Conversation

@dfuch
Copy link
Member

@dfuch dfuch commented Oct 7, 2024

UdpSocket has been observed failing again in the CI.
JDK-8265362 added a retry-once policy.
This fix proposes to retry once more, and adds a bit of delay between retries.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341637: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64) (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21388/head:pull/21388
$ git checkout pull/21388

Update a local copy of the PR:
$ git checkout pull/21388
$ git pull https://git.openjdk.org/jdk.git pull/21388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21388

View PR using the GUI difftool:
$ git pr show -t 21388

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21388.diff

Webrev

Link to Webrev Comment

…tion: Address already in use" (macos-aarch64)
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2024

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 7, 2024

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341637: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 93 new commits pushed to the master branch:

  • 1581508: 8335091: NMT: VMATree reserve_mapping and commit_mapping APIs need MEMFLAGS while un/-committing API has no MEMFLAGS arg
  • b20c5c7: 8341967: Unify os::current_file_offset and os::seek_to_file_offset across posix platforms
  • dcac4b0: 8341471: Reversed field layout caused by unstable sorting
  • e3f6503: 8341893: AArch64: Micro-optimize compressed ptr decoding
  • 037f11b: 8341708: Optimize safepoint poll encoding with smaller poll data offset
  • 8d0975a: 8336726: C2: assert(!do_asserts || projs->fallthrough_ioproj != nullptr) failed: must be found
  • fe98f86: 8226938: [TEST_BUG]GTK L&F: There is no Details button in FileChooser Dialog
  • 5c4f1ef: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser
  • 41ee582: 8341138: Rename jtreg property docker.support as container.support
  • 2e1c193: 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java
  • ... and 83 more: https://git.openjdk.org/jdk/compare/4ba170c403ae85576f84dafd4a157ba0db99873f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 7, 2024
@openjdk
Copy link

openjdk bot commented Oct 7, 2024

@dfuch The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Oct 7, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2024

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 14, 2024
@dfuch
Copy link
Member Author

dfuch commented Oct 14, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

Going to push as commit ba3774d.
Since your change was applied there have been 93 commits pushed to the master branch:

  • 1581508: 8335091: NMT: VMATree reserve_mapping and commit_mapping APIs need MEMFLAGS while un/-committing API has no MEMFLAGS arg
  • b20c5c7: 8341967: Unify os::current_file_offset and os::seek_to_file_offset across posix platforms
  • dcac4b0: 8341471: Reversed field layout caused by unstable sorting
  • e3f6503: 8341893: AArch64: Micro-optimize compressed ptr decoding
  • 037f11b: 8341708: Optimize safepoint poll encoding with smaller poll data offset
  • 8d0975a: 8336726: C2: assert(!do_asserts || projs->fallthrough_ioproj != nullptr) failed: must be found
  • fe98f86: 8226938: [TEST_BUG]GTK L&F: There is no Details button in FileChooser Dialog
  • 5c4f1ef: 8226933: [TEST_BUG]GTK L&F: There is no swatches or RGB tab in JColorChooser
  • 41ee582: 8341138: Rename jtreg property docker.support as container.support
  • 2e1c193: 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java
  • ... and 83 more: https://git.openjdk.org/jdk/compare/4ba170c403ae85576f84dafd4a157ba0db99873f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2024
@openjdk openjdk bot closed this Oct 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@dfuch Pushed as commit ba3774d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated net net-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants