8340173: Open source some Component/Panel/EventQueue tests - Set2#21398
8340173: Open source some Component/Panel/EventQueue tests - Set2#21398DamonGuy wants to merge 8 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into |
|
@DamonGuy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 60 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
test/jdk/java/awt/EventQueue/PushPopDeadlock/PushPopDeadlock.java
Outdated
Show resolved
Hide resolved
| }); | ||
| f.add(l); | ||
| f.addNotify(); | ||
| f.addNotify(); |
There was a problem hiding this comment.
The test is to use multiple addNotify and check if a LW component still works properly. So this needs 2.
test/jdk/java/awt/LightweightComponent/PopupTest/PopupTest.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/EventQueue/PushPopDeadlock/PushPopDeadlock.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/EventQueue/PushPopDeadlock/PushPopDeadlock.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/EventQueue/PushPopDeadlock/PushPopDeadlock.java
Outdated
Show resolved
Hide resolved
honkar-jdk
left a comment
There was a problem hiding this comment.
Updated changes LGTM.
test/jdk/java/awt/LightweightComponent/MultipleAddNotifyTest/MultipleAddNotifyTest.java
Show resolved
Hide resolved
test/jdk/java/awt/LightweightComponent/MultipleAddNotifyTest/MultipleAddNotifyTest.java
Show resolved
Hide resolved
test/jdk/java/awt/LightweightComponent/MultipleAddNotifyTest/MultipleAddNotifyTest.java
Show resolved
Hide resolved
|
@DamonGuy Looks like the resize indicator was the problem on windows which caused MultipleAddNotifyTest.java to fail. |
honkar-jdk
left a comment
There was a problem hiding this comment.
Updated changes LGTM.
|
/integrate |
|
Going to push as commit 97ee8bb.
Your commit was automatically rebased without conflicts. |
Following tests are added as part of this PR:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21398/head:pull/21398$ git checkout pull/21398Update a local copy of the PR:
$ git checkout pull/21398$ git pull https://git.openjdk.org/jdk.git pull/21398/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21398View PR using the GUI difftool:
$ git pr show -t 21398Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21398.diff
Webrev
Link to Webrev Comment