Skip to content

8340173: Open source some Component/Panel/EventQueue tests - Set2#21398

Closed
DamonGuy wants to merge 8 commits intoopenjdk:masterfrom
DamonGuy:8340173/set2Open
Closed

8340173: Open source some Component/Panel/EventQueue tests - Set2#21398
DamonGuy wants to merge 8 commits intoopenjdk:masterfrom
DamonGuy:8340173/set2Open

Conversation

@DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Oct 8, 2024

Following tests are added as part of this PR:

  1. /java/awt/LightweightComponent/MultipleAddNotifyTest/MultipleAddNotifyTest.java - CONVERTED TO AUTO
  2. /java/awt/LightweightComponent/PopupTest/PopupTest.java - MANUAL
  3. /java/awt/Panel/PanelRepaint/PanelRepaint.java - MANUAL
  4. /java/awt/EventQueue/PushPopDeadlock/PushPopDeadlock.java MANUAL (PROBLEM LISTED)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340173: Open source some Component/Panel/EventQueue tests - Set2 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21398/head:pull/21398
$ git checkout pull/21398

Update a local copy of the PR:
$ git checkout pull/21398
$ git pull https://git.openjdk.org/jdk.git pull/21398/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21398

View PR using the GUI difftool:
$ git pr show -t 21398

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21398.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2024

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 8, 2024

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340173: Open source some Component/Panel/EventQueue tests - Set2

Reviewed-by: honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 8, 2024
@openjdk
Copy link

openjdk bot commented Oct 8, 2024

@DamonGuy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 8, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2024

});
f.add(l);
f.addNotify();
f.addNotify();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate addNotify..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is to use multiple addNotify and check if a LW component still works properly. So this needs 2.

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changes LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 8, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 9, 2024
@honkar-jdk
Copy link
Contributor

@DamonGuy Looks like the resize indicator was the problem on windows which caused MultipleAddNotifyTest.java to fail.
Moving the click location to almost center of the lightweight component may be better as described above.

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changes LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2024
@DamonGuy
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 10, 2024

Going to push as commit 97ee8bb.
Since your change was applied there have been 60 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2024
@openjdk openjdk bot closed this Oct 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 10, 2024
@openjdk
Copy link

openjdk bot commented Oct 10, 2024

@DamonGuy Pushed as commit 97ee8bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants