8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode #21401

xmas92 · 2024-10-08T07:20:49Z

This is the implementation task for JEP 490: ZGC: Remove the Non-Generational Mode. See the JEP for details. JDK-8335850

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires a JEP request to be targeted
Change must be properly reviewed (3 reviews required, with at least 1 Reviewer, 2 Authors)
Change requires CSR request JDK-8341693 to be approved

Issues

JDK-8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode (Sub-task - P4)
JDK-8335850: JEP 490: ZGC: Remove the Non-Generational Mode (JEP)
JDK-8341693: Implement JEP 490: ZGC: Remove the Non-Generational Mode (CSR)

Reviewers

Magnus Ihse Bursie (@magicus - Reviewer)
Erik Österlund (@fisk - Reviewer)
Phil Race (@prrace - Reviewer) Review applies to e58b4c5a
Chris Plummer (@plummercj - Reviewer) Review applies to e58b4c5a
David Holmes (@dholmes-ora - Reviewer) Review applies to e58b4c5a
Stefan Karlsson (@stefank - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21401/head:pull/21401
$ git checkout pull/21401

Update a local copy of the PR:
$ git checkout pull/21401
$ git pull https://git.openjdk.org/jdk.git pull/21401/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21401

View PR using the GUI difftool:
$ git pr show -t 21401

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21401.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-10-08T07:21:15Z

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-10-08T07:22:18Z

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode

Reviewed-by: ihse, eosterlund, stefank, prr, cjplummer, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 111 new commits pushed to the master branch:

9003524: 8342588: Shenandoah: Pull shared closures together in one header
f7f5198: 8343186: hsdis build libopcodes and libbfd are not found
63c19d3: 8341977: Replace predicate walking and cloning code for Loop Peeling with a predicate visitor
158ae51: 8250659: Clarify in ParameterizedType.getRawType() doc that only Class is returned
b6f745d: 8342489: compiler/c2/irTests/TestVectorizationMismatchedAccess.java fails on big-endian platforms
bd79594: 8343037: Missing @SInCE tag on JColorChooser.showDialog overload
ceaa71e: 8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions
40f3d50: 8343211: Compile error: redefinition of 'Assembler::evmovdquw(XMMRegister,KRegister,XMMRegister,bool,int)'
60364ef: 8341273: JVMTI is not properly hiding some continuation related methods
520ddac: 8331861: [PPC64] Implement load / store assembler functions which take an Address object
... and 101 more: https://git.openjdk.org/jdk/compare/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-10-08T07:22:58Z

@xmas92 The following labels will be automatically applied to this pull request:

build
client
core-libs
graal
hotspot
serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-10-09T11:50:17Z

Webrevs

magicus

Build changes look good.

Are you on a direct track towards winning over the title of Dr Deprecator? ;-)

/reviewers 3

stefank · 2024-10-09T13:02:44Z

Looks good to me!

openjdk · 2024-10-09T13:04:07Z

@magicus
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 3 (with at least 1 Reviewer, 2 Authors).

liach · 2024-10-09T13:08:12Z

/jep jep-490

openjdk · 2024-10-09T13:09:32Z

@liach
This pull request will not be integrated until the JEP-490 has been targeted.

stefank · 2024-10-09T13:16:23Z

src/hotspot/share/runtime/arguments.cpp

@@ -521,7 +520,7 @@ static SpecialFlag const special_jvm_flags[] = {
  // -------------- Obsolete Flags - sorted by expired_in --------------

  { "MetaspaceReclaimPolicy",       JDK_Version::undefined(), JDK_Version::jdk(21), JDK_Version::undefined() },
-
+  { "ZGenerational",                JDK_Version::jdk(23), JDK_Version::jdk(24), JDK_Version::undefined() },


FTR: This line depends on what version the JEP gets targeted to.

fisk

Looks good.

prrace

the 2D/AWT test changes are fine. I've not looked at anything else.

Added tag jdk-24+19 for changeset e7c5bf4

plummercj

The serviceability related changes look good. I suppose the 6 or so SA bugs filed against the non-generational ZGC can be closed out. I have a note to myself to go through them and close if appropriate. We have JDK-8307393 filed for the lack of SA support for generational ZGC, and that is probably the only SA ZGC related issue we need to keep around.

dholmes-ora

I skimmed everything and it seems okay to me.

Thanks

openjdk · 2024-10-16T06:21:44Z

@xmas92 this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8341692
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

Added tag jdk-24+20 for changeset 7a64fbb

Added tag jdk-24+21 for changeset 8bcd492

xmas92 · 2024-10-30T11:03:58Z

Thanks for the reviews.
/integrate

openjdk · 2024-10-30T11:05:09Z

Going to push as commit 821c514.
Since your change was applied there have been 112 commits pushed to the master branch:

0fe15d6: 8343040: Clean up references to JRE in the launcher code
9003524: 8342588: Shenandoah: Pull shared closures together in one header
f7f5198: 8343186: hsdis build libopcodes and libbfd are not found
63c19d3: 8341977: Replace predicate walking and cloning code for Loop Peeling with a predicate visitor
158ae51: 8250659: Clarify in ParameterizedType.getRawType() doc that only Class is returned
b6f745d: 8342489: compiler/c2/irTests/TestVectorizationMismatchedAccess.java fails on big-endian platforms
bd79594: 8343037: Missing @SInCE tag on JColorChooser.showDialog overload
ceaa71e: 8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions
40f3d50: 8343211: Compile error: redefinition of 'Assembler::evmovdquw(XMMRegister,KRegister,XMMRegister,bool,int)'
60364ef: 8341273: JVMTI is not properly hiding some continuation related methods
... and 102 more: https://git.openjdk.org/jdk/compare/8bcd4920f1b03d0ef8e295e53557c629f05ceaa4...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-10-30T11:05:22Z

@xmas92 Pushed as commit 821c514.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode

c8f400f

openjdk bot added the csr Pull request needs approved CSR before integration label Oct 8, 2024

openjdk bot added graal graal-dev@openjdk.org serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org build build-dev@openjdk.org client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Oct 8, 2024

xmas92 added 4 commits October 8, 2024 07:50

Remove x from jdk.hotspot.agent

a793f0c

Add missing problem-listing

74dc9ca

Fix typo in TestZUncommitEvent.java

b0c4934

Remove XCollectedHeap from HSDB

e5865bc

xmas92 marked this pull request as ready for review October 9, 2024 11:46

openjdk bot added the rfr Pull request is ready for review label Oct 9, 2024

xmas92 added 6 commits October 9, 2024 12:20

Consistent order between ZArguments and GCArguments

9f2d211

Consistent albite special code style

4e4f9bb

Reorder z_globals options: product > diagnostic product > develop

7019998

Fix @requires !vm.gc.Z, must use vm.gc != "Z"

4a32f94

Fix problem-listed @requires typo

9e3d7d3

LargeWindowPaintTest.java fix id typo

22c243a

magicus approved these changes Oct 9, 2024

View reviewed changes

openjdk bot added the jep label Oct 9, 2024

stefank reviewed Oct 9, 2024

View reviewed changes

fisk approved these changes Oct 9, 2024

View reviewed changes

prrace approved these changes Oct 9, 2024

View reviewed changes

Merge tag 'jdk-24+19' into JDK-8341692

e58b4c5

Added tag jdk-24+19 for changeset e7c5bf4

plummercj approved these changes Oct 11, 2024

View reviewed changes

dholmes-ora approved these changes Oct 16, 2024

View reviewed changes

openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Oct 16, 2024

Merge tag 'jdk-24+20' into JDK-8341692

76c5d0c

Added tag jdk-24+20 for changeset 7a64fbb

openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Oct 18, 2024

stefank approved these changes Oct 18, 2024

View reviewed changes

xmas92 added 2 commits October 25, 2024 07:33

Merge tag 'jdk-24+21' into JDK-8341692

67549bb

Added tag jdk-24+21 for changeset 8bcd492

Remove GCName::Z

eef214b

stefank approved these changes Oct 25, 2024

View reviewed changes

fisk approved these changes Oct 25, 2024

View reviewed changes

openjdk bot removed csr Pull request needs approved CSR before integration jep labels Oct 29, 2024

magicus approved these changes Oct 30, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 30, 2024

openjdk bot added the integrated Pull request has been integrated label Oct 30, 2024

openjdk bot closed this Oct 30, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2024

8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode #21401

8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode #21401

Uh oh!

Conversation

xmas92 commented Oct 8, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issues

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Oct 8, 2024

Uh oh!

openjdk bot commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 8, 2024

Uh oh!

mlbridge bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

magicus left a comment

Choose a reason for hiding this comment

Uh oh!

stefank commented Oct 9, 2024

Uh oh!

openjdk bot commented Oct 9, 2024

Uh oh!

liach commented Oct 9, 2024

Uh oh!

openjdk bot commented Oct 9, 2024

Uh oh!

stefank Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

fisk left a comment

Choose a reason for hiding this comment

Uh oh!

prrace left a comment

Choose a reason for hiding this comment

Uh oh!

plummercj left a comment

Choose a reason for hiding this comment

Uh oh!

dholmes-ora left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Oct 16, 2024

Uh oh!

xmas92 commented Oct 30, 2024

Uh oh!

openjdk bot commented Oct 30, 2024

Uh oh!

openjdk bot commented Oct 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

8 participants

xmas92 commented Oct 8, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Oct 8, 2024 •

edited

Loading

mlbridge bot commented Oct 9, 2024 •

edited

Loading