8341832: Incorrect continuation address of synthetic SIGSEGV for APX in product builds

[jatin-bhateja]

• Enable APX EGPRs state save restoration check which triggers synthetic SIGSEGV and verifies modified EGPRs state across OS signal handling for non-product builds to match with corresponding logic in signal handlers.

• Currently we haven't enabled APX support in product builds and intend to do so once entire planned support (JDK-8329030) is validated and checked into JDK-mainline, we are following incremental development approach for APX and hence don't want partial APX support to be enabled in intermediate releases.

Kindly review.

Best Regards,
Jatin

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341832: Incorrect continuation address of synthetic SIGSEGV for APX in product builds (Bug - P3)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Sandhya Viswanathan (@sviswa7 - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21419/head:pull/21419
$ git checkout pull/21419

Update a local copy of the PR:
$ git checkout pull/21419
$ git pull https://git.openjdk.org/jdk.git pull/21419/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21419

View PR using the GUI difftool:
$ git pr show -t 21419

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21419.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jatin-bhateja This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341832: Incorrect continuation address of synthetic SIGSEGV for APX in product builds

Reviewed-by: thartmann, sviswanathan, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• fcc9c8d: 8341854: Incorrect clearing of ZF in fast_unlock_lightweight on x86
• 38c1d65: 8337980: Javac allows invocation of an inherited instance method from a static method
• 950e3a7: 8341625: Improve ZipFile validation of the END header
• e704c05: 8340547: Starting many threads can delay safepoints
• c30ad01: 8325495: C2: implement optimization for series of Add of unique value
• ff2f39f: 8340214: C2 compilation asserts with "no node with a side effect" in PhaseIdealLoop::try_sink_out_of_loop
• ecc77a5: 8336702: C2 compilation fails with "all memory state should have been processed" assert
• d936556: 8341633: StatSampler::assert_system_property: Print the keys and values of the assert
• 3fba170: 8340786: Introduce Predicate classes with predicate iterators and visitors for simplified walking
• 047c2d7: 8341141: Optimize DirectCodeBuilder
• ... and 8 more: https://git.openjdk.org/jdk/compare/966eb7232ff867d9a68269d5a2007da20259565f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jatin-bhateja The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f8b73406)

[jatin-bhateja]

/label add hotspot-compiler-dev

[openjdk]

@jatin-bhateja
The hotspot-compiler label was successfully added.

[jatin-bhateja]

Hi @TobiHartmann , @vnkozlov , @sviswa7 can you kindly check this small patch.

[TobiHartmann]

Looks reasonable to me.

[sviswa7]

Looks good to me.

[vnkozlov]

Good.

[jatin-bhateja]

/integrate

[openjdk]

Going to push as commit 3180aaa.
Since your change was applied there have been 20 commits pushed to the master branch:

• 3ab519f: 8341424: GHA: Collect hs_errs from build time failures
• a24525b: 8339320: Optimize ClassFile Utf8EntryImpl#inflate
• fcc9c8d: 8341854: Incorrect clearing of ZF in fast_unlock_lightweight on x86
• 38c1d65: 8337980: Javac allows invocation of an inherited instance method from a static method
• 950e3a7: 8341625: Improve ZipFile validation of the END header
• e704c05: 8340547: Starting many threads can delay safepoints
• c30ad01: 8325495: C2: implement optimization for series of Add of unique value
• ff2f39f: 8340214: C2 compilation asserts with "no node with a side effect" in PhaseIdealLoop::try_sink_out_of_loop
• ecc77a5: 8336702: C2 compilation fails with "all memory state should have been processed" assert
• d936556: 8341633: StatSampler::assert_system_property: Print the keys and values of the assert
• ... and 10 more: https://git.openjdk.org/jdk/compare/966eb7232ff867d9a68269d5a2007da20259565f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jatin-bhateja Pushed as commit 3180aaa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.