8341138: Rename jtreg property docker.support as container.support

[rsunderbabu]

The System property "docker.support" defined in VMProps gives a wrong impression that it is tied to docker alone. The property is common for any container runtime. Hence, it needs to be renamed as "container.support".

Positive Testing:
tier1,tier2,tier3 - to check stability
tier5 - to run container tests

Negative Testing:
Ran the following groups in hosts where container is not present.
open/test/hotspot/jtreg/containers/
open/test/jdk/jdk/internal/platform/docker/
open/test/jdk/jdk/internal/platform/cgroup/

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341138: Rename jtreg property docker.support as container.support (Enhancement - P4)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)
• Mikhailo Seledtsov (@mseledts - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21423/head:pull/21423
$ git checkout pull/21423

Update a local copy of the PR:
$ git checkout pull/21423
$ git pull https://git.openjdk.org/jdk.git pull/21423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21423

View PR using the GUI difftool:
$ git pr show -t 21423

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21423.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rsunderbabu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rsunderbabu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341138: Rename jtreg property docker.support as container.support

Reviewed-by: sgehwolf, mseledtsov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• 24eb360: 8341906: Optimize ClassFile writing BufBuffer
• cd4981c: 8341257: Open source few DND tests - Set1
• 06f34d7: 8339651: ShenandoahPacer::setup_for_mark, ShenandoahPacer::setup_for_updaterefs and ShenandoahPacer::setup_for_evac runtime error: division by zero
• 97ee8bb: 8340173: Open source some Component/Panel/EventQueue tests - Set2
• 2a6f030: 8339974: Graphics2D.drawString doesn't always work with Font derived from AffineTransform
• 32f817a: 8340978: Open source few DnD tests - Set6
• a5cad0e: 8341791: Fix ExceptionOccurred in java.prefs
• 7eb5535: 8341789: Fix ExceptionOccurred in java.base
• 76541b0: 8341792: Fix ExceptionOccurred in java.security.jgss
• 6fad6af: 8341819: LightweightSynchronizer::enter_for races with deflation
• ... and 31 more: https://git.openjdk.org/jdk/compare/047c2d7f2676b8c3c8b5645134fb5c00c540e43f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa, @mseledts) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@rsunderbabu The following labels will be automatically applied to this pull request:

• core-libs
• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3e36b519)
• 00: Full (75001218)

[jerboaa]

Seems OK to me. One minor nit.

[jerboaa]

Suggested change

	// Use this property to specify container location on your system.
	// Use this property to specify container runtime location (e.g. docker) on your system.

[mseledts]

Changes look good to me. Thank you for making these changes.

[rsunderbabu]

/integrate

[openjdk]

@rsunderbabu
Your change (at version 3e36b51) is now ready to be sponsored by a Committer.

[lmesnik]

/integrate

[lmesnik]

/sponsor

[openjdk]

@lmesnik Only the author (@rsunderbabu) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

[openjdk]

Going to push as commit 41ee582.
Since your change was applied there have been 54 commits pushed to the master branch:

• 2e1c193: 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java
• 2db3397: 8341797: Fix ExceptionOccurred in jdk.jdi
• c4965d9: 8341794: Fix ExceptionOccurred in jdk.attach
• 3f53d57: 8340327: A common framework to support public key algorithms with standard parameter sets
• 0a57fe1: 8341178: TypeRawPtr::add_offset may be "miscompiled" due to UB
• 1f6bd0c: 8341972: java/awt/dnd/DnDRemoveFocusOwnerCrashTest.java timed out after JDK-8341257
• 7276a1b: 8341784: Refactor TypeVect to use a BasicType instead of a const Type*
• 6133866: 8341070: javac fails with an exception when compiling import module under source level 8
• 519544c: 8341909: G1: Add region index to region printer output
• 7c0dbf8: 8341820: Check return value of hcreate_r
• ... and 44 more: https://git.openjdk.org/jdk/compare/047c2d7f2676b8c3c8b5645134fb5c00c540e43f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik @rsunderbabu Pushed as commit 41ee582.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.