8340279: Open source several AWT Dialog tests - Batch 2

[TejeshR13]

Open source these AWT Dialog tests:

java/awt/Dialog/PrintToFileTest/PrintToFileRevoked.java
java/awt/Dialog/PrintToFileTest/PrintToFileGranted.java
java/awt/Dialog/TopmostModalDialogTest.java
java/awt/Dialog/FileDialogFilterTest.java
java/awt/Dialog/DialogSystemMenu/DialogSystemMenu.java

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warnings

 ⚠️ Patch contains a binary file (test/jdk/java/awt/Dialog/DialogSystemMenu/icon24x24.gif)
 ⚠️ Patch contains a binary file (test/jdk/java/awt/Dialog/DialogSystemMenu/iconone.gif)
 ⚠️ Patch contains a binary file (test/jdk/java/awt/Dialog/DialogSystemMenu/icontwo.gif)

Issue

• JDK-8340279: Open source several AWT Dialog tests - Batch 2 (Bug - P4) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

• Phil Race (@prrace - Reviewer) Review applies to 99882abc
• Abhishek Kumar (@kumarabhi006 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21466/head:pull/21466
$ git checkout pull/21466

Update a local copy of the PR:
$ git checkout pull/21466
$ git pull https://git.openjdk.org/jdk.git pull/21466/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21466

View PR using the GUI difftool:
$ git pr show -t 21466

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21466.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340279: Open source several AWT Dialog tests - Batch 2

Reviewed-by: abhiscxk, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@TejeshR13 this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout branch_8340279
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@TejeshR13 The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full (9a1eafab)
• 01: Full (99882abc)
• 00: Full (86a5b102)

[DamonGuy]

@TejeshR13 Seems like you have a merge-conflict that you should resolve since this involves the Problem list.

[TejeshR13]

@TejeshR13 Seems like you have a merge-conflict that you should resolve since this involves the Problem list.

Yeah, have resolved it now.

[TejeshR13]

/integrate

[openjdk]

@TejeshR13 Since your change was applied there have been 57 commits pushed to the master branch:

• f6fe5ea: 8341072: Open source several AWT Canvas and Rectangle related tests
• 22a1fee: 8341328: Refactor initial Assertion Predicate creation into separate classes
• 58d39c3: 8340313: Crash due to invalid oop in nmethod after C1 patching
• 3da6890: 8338751: ConfigureNotify behavior has changed in KWin 6.2
• 4e703b2: 8340140: Open some dialog awt tests 3
• b4ab290: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1
• 2853852: 8342332: [JVMCI] Export CompilerToVM::Data::dtanh
• ed68096: 8341862: PPC64: C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR
• d4f0ba7: 8342439: Build failure after 8338023
• 44151f4: 8342145: File libCreationTimeHelper.c compile fails on Alpine
• ... and 47 more: https://git.openjdk.org/jdk/compare/037f11b864734734dd7fbce029b2e8b4bc17f3ab...master

It was not possible to rebase your changes automatically. Please merge master into your branch and try again.

[TejeshR13]

/integrate

[openjdk]

Going to push as commit e0dabfb.

[openjdk]

@TejeshR13 Pushed as commit e0dabfb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.