8256111: Create implementation for NSAccessibilityStaticText protocol

[pankaj-bansal]

Create implementation for NSAccessibilityStaticText protocol

For testing that Label accessibility works fine, I have used something like https://docs.oracle.com/javase/tutorial/uiswing/examples/components/LabelDemoProject/src/components/LabelDemo.java. I also tried few other labels with html text. I have verified that the Voice Over output for JLables is same before and after this change.

The class CommonTextAccessibility has most of the code taken from JavaTextAccessibility. Only the functions needed for StaticTextAccessibility have been taken as of now. Few more (not all) functions will be added to this class from JavaTextAccessiblity when work is done for NavigableStaticText or TextField, TextArea, Text, Password etc accessibility roles.

I could not see AccessibleRole.HYPERLINK or "hyperlink" role being used anywhere. As we are reworking the implementation, I have included both roles "label" and "hyperlink" as of now.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8256111: Create implementation for NSAccessibilityStaticText protocol

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer) ⚠️ Review applies to 662680b
• Alexander Zuev (@azuev-java - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2147/head:pull/2147
$ git checkout pull/2147

[bridgekeeper]

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pankaj-bansal The following label will be automatically applied to this pull request:

• awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (af3c0d9)
• 00: Full (662680b)

[openjdk]

@pankaj-bansal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256111: Create implementation for NSAccessibilityStaticText protocol

Reviewed-by: serb, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

• 7ed8ba1: 8256814: WeakProcessorPhases may be redundant
• bfac3fb: 8260212: Shenandoah: resolve-only UpdateRefsMode is not used
• 58ceb25: 8259842: Remove Result cache from StringCoding
• d066f2b: 8260030: Improve stringStream buffer handling
• 1452280: 8164484: Unity, JTable cell editor, javax/swing/JComboBox/6559152/bug6559152.java
• a70acf2: 8259928: compiler/jvmci tests fail with -Xint
• ba38661: 8259882: Reduce the inclusion of perfData.hpp
• 92c2f08: 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
• a7c2ebc: 8239894: Xserver crashes when the wrong high refresh rate is used
• 2f47c39: 8259943: FileDescriptor.close0 does not handle EINTR
• ... and 55 more: https://git.openjdk.java.net/jdk/compare/e93f08e2ac6803bb225a528c8dabd9f5b268b8a9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[azuev-java]

Just wondering: here you don't include nullability flags, but in StaticTextAccessibility you do. Any reason why such inconsistency?

[pankaj-bansal]

There is no specific reason as such. I just thought of CommonTextAccessibility class as more of a helper class, so did not added these things here. But yes, it makes sense to be consistent. I will add the flag here as well and update the PR.

[pankaj-bansal]

/integrate

[openjdk]

@pankaj-bansal Since your change was applied there have been 66 commits pushed to the master branch:

• f928265: 8260009: InstanceKlass::has_as_permitted_subclass() fails if subclass was redefined
• 7ed8ba1: 8256814: WeakProcessorPhases may be redundant
• bfac3fb: 8260212: Shenandoah: resolve-only UpdateRefsMode is not used
• 58ceb25: 8259842: Remove Result cache from StringCoding
• d066f2b: 8260030: Improve stringStream buffer handling
• 1452280: 8164484: Unity, JTable cell editor, javax/swing/JComboBox/6559152/bug6559152.java
• a70acf2: 8259928: compiler/jvmci tests fail with -Xint
• ba38661: 8259882: Reduce the inclusion of perfData.hpp
• 92c2f08: 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
• a7c2ebc: 8239894: Xserver crashes when the wrong high refresh rate is used
• ... and 56 more: https://git.openjdk.java.net/jdk/compare/e93f08e2ac6803bb225a528c8dabd9f5b268b8a9...master

Your commit was automatically rebased without conflicts.

Pushed as commit acbcde8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.