8256111: Create implementation for NSAccessibilityStaticText protocol #2147
Conversation
|
|
|
@pankaj-bansal The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
@pankaj-bansal This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 65 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
| } | ||
| - (NSString *)accessibilityValueAttribute; | ||
| - (NSRange)accessibilityVisibleCharacterRangeAttribute; | ||
| - (NSString *)accessibilityStringForRangeAttribute:(NSRange)parameter; |
There was a problem hiding this comment.
Just wondering: here you don't include nullability flags, but in StaticTextAccessibility you do. Any reason why such inconsistency?
There was a problem hiding this comment.
There is no specific reason as such. I just thought of CommonTextAccessibility class as more of a helper class, so did not added these things here. But yes, it makes sense to be consistent. I will add the flag here as well and update the PR.
|
/integrate |
openjdk
bot
added
integrated
|
@pankaj-bansal Since your change was applied there have been 66 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit acbcde8. |
Create implementation for NSAccessibilityStaticText protocol
For testing that Label accessibility works fine, I have used something like https://docs.oracle.com/javase/tutorial/uiswing/examples/components/LabelDemoProject/src/components/LabelDemo.java. I also tried few other labels with html text. I have verified that the Voice Over output for JLables is same before and after this change.
The class CommonTextAccessibility has most of the code taken from JavaTextAccessibility. Only the functions needed for StaticTextAccessibility have been taken as of now. Few more (not all) functions will be added to this class from JavaTextAccessiblity when work is done for NavigableStaticText or TextField, TextArea, Text, Password etc accessibility roles.
I could not see AccessibleRole.HYPERLINK or "hyperlink" role being used anywhere. As we are reworking the implementation, I have included both roles "label" and "hyperlink" as of now.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2147/head:pull/2147$ git checkout pull/2147