8255348: NPE in PKIXCertPathValidator event logging code

[coffeys]

Correction of NPE and updating of test cases. Minor refactoring of test library also.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8255348: NPE in PKIXCertPathValidator event logging code

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2150/head:pull/2150
$ git checkout pull/2150

[bridgekeeper]

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coffeys The following labels will be automatically applied to this pull request:

• hotspot-jfr
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8a344a8)
• 00: Full (a59dd59)

[seanjmullan]

You could use the anchorCert variable which was set earlier instead of calling getTrustedCert() again.

[seanjmullan]

Per the TrustAnchor API, you can't create a TrustAnchor with a null public key, so I don't think you need this check.

[mlbridge]

Mailing list message from Se=c3=a1n Coffey on hotspot-jfr-dev:

Thanks for the comments Sean. Code updated.

https://github.com//pull/2150/commits/8a344a85303297f17a6e75e7c1f423c2d16c451a

regards,
Sean.

On 21/01/2021 19:47, Sean Mullan wrote:

[openjdk]

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255348: NPE in PKIXCertPathValidator event logging code

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 263 new commits pushed to the master branch:

• 154e1d6: 8259009: G1 heap summary should be shown in "Heap Parameters" window on HSDB
• acbcde8: 8256111: Create implementation for NSAccessibilityStaticText protocol
• f928265: 8260009: InstanceKlass::has_as_permitted_subclass() fails if subclass was redefined
• 7ed8ba1: 8256814: WeakProcessorPhases may be redundant
• bfac3fb: 8260212: Shenandoah: resolve-only UpdateRefsMode is not used
• 58ceb25: 8259842: Remove Result cache from StringCoding
• d066f2b: 8260030: Improve stringStream buffer handling
• 1452280: 8164484: Unity, JTable cell editor, javax/swing/JComboBox/6559152/bug6559152.java
• a70acf2: 8259928: compiler/jvmci tests fail with -Xint
• ba38661: 8259882: Reduce the inclusion of perfData.hpp
• ... and 253 more: https://git.openjdk.java.net/jdk/compare/f91f92dcaadca3e5e7fd8d1300d8e24f7872f562...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coffeys]

/integrate

[openjdk]

@coffeys Since your change was applied there have been 264 commits pushed to the master branch:

• a97f3c1: 8258853: Support separate function declaration and definition with ENABLE_IF-based SFINAE
• 154e1d6: 8259009: G1 heap summary should be shown in "Heap Parameters" window on HSDB
• acbcde8: 8256111: Create implementation for NSAccessibilityStaticText protocol
• f928265: 8260009: InstanceKlass::has_as_permitted_subclass() fails if subclass was redefined
• 7ed8ba1: 8256814: WeakProcessorPhases may be redundant
• bfac3fb: 8260212: Shenandoah: resolve-only UpdateRefsMode is not used
• 58ceb25: 8259842: Remove Result cache from StringCoding
• d066f2b: 8260030: Improve stringStream buffer handling
• 1452280: 8164484: Unity, JTable cell editor, javax/swing/JComboBox/6559152/bug6559152.java
• a70acf2: 8259928: compiler/jvmci tests fail with -Xint
• ... and 254 more: https://git.openjdk.java.net/jdk/compare/f91f92dcaadca3e5e7fd8d1300d8e24f7872f562...master

Your commit was automatically rebased without conflicts.

Pushed as commit 18eb6d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.