8341584: Test java/foreign/TestUpcallStress.java intermittent timeout with -Xcomp

[sendaoYan]

Hi all,
Test java/foreign/TestUpcallStress.java intermittent timeout with -Xcomp, and this test use a very precise race, thus -Xcomp probably will never trigger the problematic use-case. So this test not suitable for -Xcomp mode.I add @requires vm.compMode != "Xcomp" to exclude from Xcomp testing and remove this test from ProblemList-Xcomp.txt.
Trivial fix, test-fix only, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341584: Test java/foreign/TestUpcallStress.java intermittent timeout with -Xcomp (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Jorn Vernee (@JornVernee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21512/head:pull/21512
$ git checkout pull/21512

Update a local copy of the PR:
$ git checkout pull/21512
$ git pull https://git.openjdk.org/jdk.git pull/21512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21512

View PR using the GUI difftool:
$ git pr show -t 21512

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21512.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341584: Test java/foreign/TestUpcallStress.java intermittent timeout with -Xcomp

Reviewed-by: jpai, jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 117 new commits pushed to the master branch:

• c9f3840: 8342679: Clean up PreviewFeature.Feature
• 2da7f2b: 8342787: Move misplaced TestTemplateAssertionPredicateWithTwoUCTs.java from src to test directory
• de441c2: 8342633: javax/management/security/HashedPasswordFileTest.java creates tmp file in src dir
• bf92c49: 8342704: GHA: Report truncation is broken after JDK-8341424
• 8bcd492: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option
• 7133d1b: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
• 8276a41: 8342715: x86 unused orw instruction encoding could be removed
• 5a4b180: 8342011: Conditionally compile ReservedHeapSpace compressed heap support
• e0c6480: 8338570: sun/font/HBShaper - mismatch in return type of FFM upcall function description and native invocation
• 7158322: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones
• ... and 107 more: https://git.openjdk.org/jdk/compare/bd6264420b9f248999dd8387c25c549b08bd193a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a0d6e5ff)

[jaikiran]

The change looks OK to me. Please wait for Jorn @JornVernee to take a look, before integrating.

[jaikiran]

@sendaoYan I forgot to ask, were you able to verify that this change continues to prevent the failures that were noticed previously?

[sendaoYan]

The change looks OK to me. Please wait for Jorn @JornVernee to take a look, before integrating.

Okey.

[sendaoYan]

@sendaoYan I forgot to ask, were you able to verify that this change continues to prevent the failures that were noticed previously?

Yes, I have verify that locally. After the @requires flags has been added, jtreg will not select this test in Xcomp test mode.

[JornVernee]

Looks good, thanks for making this change.

[sendaoYan]

Thanks for the review.
/integrate

[openjdk]

Going to push as commit 3b71657.
Since your change was applied there have been 118 commits pushed to the master branch:

• 004aaea: 8342330: C2: "node pinned on loop exit test?" assert failure
• c9f3840: 8342679: Clean up PreviewFeature.Feature
• 2da7f2b: 8342787: Move misplaced TestTemplateAssertionPredicateWithTwoUCTs.java from src to test directory
• de441c2: 8342633: javax/management/security/HashedPasswordFileTest.java creates tmp file in src dir
• bf92c49: 8342704: GHA: Report truncation is broken after JDK-8341424
• 8bcd492: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option
• 7133d1b: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
• 8276a41: 8342715: x86 unused orw instruction encoding could be removed
• 5a4b180: 8342011: Conditionally compile ReservedHeapSpace compressed heap support
• e0c6480: 8338570: sun/font/HBShaper - mismatch in return type of FFM upcall function description and native invocation
• ... and 108 more: https://git.openjdk.org/jdk/compare/bd6264420b9f248999dd8387c25c549b08bd193a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 3b71657.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.