Skip to content

Conversation

@mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented Oct 16, 2024

#20657 adds x86_64 intrinsic for tanh. Exporting CompilerToVM::Data::dtanh allows JVMCI compiler to reuse the same HotSpot stub.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8342332: [JVMCI] Export CompilerToVM::Data::dtanh (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21535/head:pull/21535
$ git checkout pull/21535

Update a local copy of the PR:
$ git checkout pull/21535
$ git pull https://git.openjdk.org/jdk.git pull/21535/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21535

View PR using the GUI difftool:
$ git pr show -t 21535

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21535.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2024

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342332: [JVMCI] Export CompilerToVM::Data::dtanh

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 84 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@mur47x111 The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Oct 16, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2024

Webrevs

Copy link
Contributor

@tkrodriguez tkrodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 16, 2024
@mur47x111
Copy link
Contributor Author

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

Going to push as commit 2853852.
Since your change was applied there have been 84 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 16, 2024
@openjdk openjdk bot closed this Oct 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@mur47x111 Pushed as commit 2853852.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mur47x111 mur47x111 deleted the JDK-8342332 branch October 16, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants