8340389: vmTestbase/gc/gctests/PhantomReference/phantom001/TestDescription.java Test exit code: 97 with -Xcomp UseAVX=3

[tschatzl]

Hi all,

please review this fix to the phantom001 test to do much less garbage collections that inhibit passing the test.

Testing: gha, running the test with and without the change for 500 times with the problematic options - fails 379 times without the change, passes all runs with the change.

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340389: vmTestbase/gc/gctests/PhantomReference/phantom001/TestDescription.java Test exit code: 97 with -Xcomp UseAVX=3 (Bug - P2)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21538/head:pull/21538
$ git checkout pull/21538

Update a local copy of the PR:
$ git checkout pull/21538
$ git pull https://git.openjdk.org/jdk.git pull/21538/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21538

View PR using the GUI difftool:
$ git pr show -t 21538

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21538.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340389: vmTestbase/gc/gctests/PhantomReference/phantom001/TestDescription.java Test exit code: 97 with -Xcomp UseAVX=3

Reviewed-by: shade, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 44151f4: 8342145: File libCreationTimeHelper.c compile fails on Alpine
• 709914f: 8338023: Support two vector selectFrom API
• c34fb2c: 8338883: Show warning when CreateCoredumpOnCrash set, but core dump will not happen
• 7625b29: 8329597: C2: Intrinsify Reference.clear
• 1cc3223: 8336911: ZGC: Division by zero in heuristics after JDK-8332717
• cf5bb12: Merge
• 490d099: 8335713: Enhance vectorization analysis
• c89f76c: 8332644: Improve graph optimizations
• d9f6383: 8331446: Improve deserialization support
• dadcee1: 8307383: Enhance DTLS connections
• ... and 6 more: https://git.openjdk.org/jdk/compare/ebc17c7c8d6febd5a887309d1b7a466bcd2cc0a9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (2c707769)
• 00: Full (5327996b)

[shipilev]

There is a comment a few lines above:

// There are scenarios where one WB.fillGC() isn't enough,
// but 10 iterations really ought to be sufficient.

Do you know what that is about?

[tschatzl]

There is a comment a few lines above:

// There are scenarios where one WB.fillGC() isn't enough,
// but 10 iterations really ought to be sufficient.

Do you know what that is about?

This is a renmant of the original change that forced a full gc every iteration. This is not necessary, the object should be finalizable after the first full gc already. That is, the comment is wrong. However we might need to wait a bit until the finalizer actually executes. I updated the comment.

I did not try optimizing the maximum wait time.

[shipilev]

OK then, thanks!

[tschatzl]

Thanks @shipilev @walulyai for your reviews.
/integrate

[openjdk]

Going to push as commit d6f8b46.
Since your change was applied there have been 35 commits pushed to the master branch:

• 8e16e67: 8342329: G1: Rename G1HeapRegionManager::_allocated_heapregions_length
• 3ebfc6c: 8342336: Optimize ClassFile imports
• 7ff4ea8: 8341966: Broken annotated module may lead to an exception in javac
• 9bdface: 8341622: Tag-specific disabled default decorators for UnifiedLogging
• 1ea1f33: 8340336: Open some checkbox awt tests
• 7a64fbb: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows
• 8862ca0: 8342338: Remove redundant IIOPURLTest.java
• f9208fa: 8341715: PPC64: ObjectMonitor::_owner should be reset unconditionally in nmethod unlocking
• fa39e84: 8342042: PPC64: compiler_fast_unlock_object flags failure instead of success
• e0dabfb: 8340279: Open source several AWT Dialog tests - Batch 2
• ... and 25 more: https://git.openjdk.org/jdk/compare/ebc17c7c8d6febd5a887309d1b7a466bcd2cc0a9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit d6f8b46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.