Skip to content

Conversation

@jatin-bhateja
Copy link
Member

@jatin-bhateja jatin-bhateja commented Oct 16, 2024

Fix failing build.

Due to notification problem with integration system.

Thanks,
Jatin


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21547/head:pull/21547
$ git checkout pull/21547

Update a local copy of the PR:
$ git checkout pull/21547
$ git pull https://git.openjdk.org/jdk.git pull/21547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21547

View PR using the GUI difftool:
$ git pr show -t 21547

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21547.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2024

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jatin-bhateja
Copy link
Member Author

/label add hotspot-compiler-dev

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@jatin-bhateja This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342439: Build failure after 8338023

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@jatin-bhateja
The hotspot-compiler label was successfully added.

@jatin-bhateja jatin-bhateja changed the title Build issue JDK-8342439 8342439: Build issue JDK-8342439 Oct 16, 2024
@liach
Copy link
Member

liach commented Oct 16, 2024

Can we change the title of the JBS issue to be more descriptive, like "Build failure after 8338023"? So the PR title will be like 8342439: Build failure after 8338023.

This is in part our fault, that we should test in CI after merging master.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2024
@jatin-bhateja jatin-bhateja changed the title 8342439: Build issue JDK-8342439 8342439: Build failure after 8338023 Oct 16, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2024

Webrevs

@jatin-bhateja
Copy link
Member Author

@vnkozlov , @liach , Kindly approve.

@liach
Copy link
Member

liach commented Oct 16, 2024

Yep, running a build locally with your branch merged into master. Will approve once build passes.

Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build fixed in my local OracleJDK linux-x64 setup.

@jatin-bhateja
Copy link
Member Author

/integrate

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

Going to push as commit d4f0ba7.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 16, 2024
@openjdk openjdk bot closed this Oct 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@jatin-bhateja Pushed as commit d4f0ba7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants