-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8342439: Build failure after 8338023 #21547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into |
|
/label add hotspot-compiler-dev |
|
@jatin-bhateja This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
@jatin-bhateja |
|
Can we change the title of the JBS issue to be more descriptive, like "Build failure after 8338023"? So the PR title will be like This is in part our fault, that we should test in CI after merging master. |
|
Yep, running a build locally with your branch merged into master. Will approve once build passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build fixed in my local OracleJDK linux-x64 setup.
|
/integrate |
|
Going to push as commit d4f0ba7. |
|
@jatin-bhateja Pushed as commit d4f0ba7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Fix failing build.
Due to notification problem with integration system.
Thanks,
Jatin
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21547/head:pull/21547$ git checkout pull/21547Update a local copy of the PR:
$ git checkout pull/21547$ git pull https://git.openjdk.org/jdk.git pull/21547/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21547View PR using the GUI difftool:
$ git pr show -t 21547Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21547.diff
Webrev
Link to Webrev Comment