8342442: Static ACVP sample tests

[wangweij]

Here we have a launcher and several algorithm-specific tests. Users can populate "internalProjection.json" files generated by NIST's ACVP Server into the data directory and test them with the launcher.

Currently, only SHA2, SHA3, ML-KEM, and ML-DSA are supported.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342442: Static ACVP sample tests (Enhancement - P4)

Reviewers

• Ben Perez (@blperez01 - Committer) Review applies to 9b04ea1a
• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21548/head:pull/21548
$ git checkout pull/21548

Update a local copy of the PR:
$ git checkout pull/21548
$ git pull https://git.openjdk.org/jdk.git pull/21548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21548

View PR using the GUI difftool:
$ git pr show -t 21548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21548.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342442: Static ACVP sample tests

Reviewed-by: mullan, bperez

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 2614c99: 8343793: Test java/foreign/TestMemorySession.java is timing out
• 8a69893: 8343819: Link Float.NaN and Double.NaN to equivalence discussion in Double
• 52c0b09: 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed
• 0329855: 8343804: Show the default time zone with -XshowSettings option

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 14: Full - Incremental (12df6fff)
• 13: Full - Incremental (39601d8d)
• 12: Full - Incremental (34f9f8a8)
• 11: Full - Incremental (a7e22873)
• 10: Full - Incremental (5cba8ff6)
• 09: Full - Incremental (f71596d5)
• 08: Full - Incremental (dc84f8fc)
• 07: Full - Incremental (9b04ea1a)
• 06: Full - Incremental (1f6126ff)
• 05: Full - Incremental (587f61b8)
• 04: Full - Incremental (1ff91a3e)
• 03: Full - Incremental (2d5cc81f)
• 02: Full - Incremental (cf2765d0)
• 01: Full - Incremental (0be8f827)
• 00: Full (c9124040)

[mcpowers]

This looks good to me. Only a few grammatical changes. Why the inclusion of SHA?

[wangweij]

This looks good to me. Only a few grammatical changes. Why the inclusion of SHA?

Thanks. Fixed. I would like to include as many algorithms as possible. MessageDigest seems to be the most basic one so I worked on it.

[blperez01]

Perhaps it would be good to rename "Launcher" to "ACVP_Launcher" or "ACVP_Test" so its functionality is more explicit. Otherwise looks good

[wangweij]

I organized everything within a directory named acvp to avoid using the term in the class name. You can think of this directory as effectively serving as a namespace.

[RogerRiggs]

The duplication in utilities (RandomSource and xeh(String) should be avoided.
Perhaps in the test library or a common utility class.

[seanjmullan]

Do we have plans to add more tests in the future? I see test data for AES_GCM, HMAC-SHA*, RSA, among others at the github page.

[wangweij]

Do we have plans to add more tests in the future? I see test data for AES_GCM, HMAC-SHA*, RSA, among others at the github page.

It's definitely better to add more, but that's not in my plan yet. We can discuss with the test team on how to cover more algorithms.

[wangweij]

/integrate

[openjdk]

Going to push as commit f400896.
Since your change was applied there have been 5 commits pushed to the master branch:

• 325a2c3: 8343848: Fix typo of property name in TestOAEPPadding after 8341927
• 2614c99: 8343793: Test java/foreign/TestMemorySession.java is timing out
• 8a69893: 8343819: Link Float.NaN and Double.NaN to equivalence discussion in Double
• 52c0b09: 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed
• 0329855: 8343804: Show the default time zone with -XshowSettings option

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit f400896.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.