8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible

[manukumarvs]

This issue can be fixed by setting the preferred scrollable viewport size of the two tables using
JTable table = new JTable(data, columnNames);
+ table.setPreferredScrollableViewportSize(table.getPreferredSize());
JTable secondTable = new JTable(data, columnNames);
+ secondTable.setPreferredScrollableViewportSize(secondTable.getPreferredSize());

The other changes in imports section are just re-arrangements and expansion of imports.

Testing: This is a manual test and it is tested and verified manually in my local system
Screenshots of before and after the fix are attached in the bug.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible (Bug - P4)

Reviewers

• Artem Semenov (@savoptik - Committer) Review applies to d4d83388
• Abhishek Kumar (@kumarabhi006 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21549/head:pull/21549
$ git checkout pull/21549

Update a local copy of the PR:
$ git checkout pull/21549
$ git pull https://git.openjdk.org/jdk.git pull/21549/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21549

View PR using the GUI difftool:
$ git pr show -t 21549

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21549.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible

Reviewed-by: abhiscxk, asemenov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 206 new commits pushed to the master branch:

• 37aa320: 8342376: More reliable OOM handling in ExceptionDuringDumpAtObjectsInitPhase test
• 18bcbf7: 8341052: SHA-512 implementation using SHA-NI
• 54a744b: 8340553: ZipEntry field validation does not take into account the size of a CEN header
• 18b55ce: 8342653: Fix minor doc issues in AnnotatedElement
• 153ad91: 8338126: C2 SuperWord: VectorCastF2HF / vcvtps2ph produces wrong results for vector length 2
• 80ec552: 8328528: C2 should optimize long-typed parallel iv in an int counted loop
• 330f2b5: 8342295: compiler/jvmci/TestJVMCISavedProperties.java fails due to garbage in output
• 1f35748: 8342102: ZGC: Optimize copy constructors in ZPhysicalMemory
• 66ddaaa: 8340241: RISC-V: Returns mispredicted
• 07f550b: 8340818: Add a new jtreg test root to test the generated documentation
• ... and 196 more: https://git.openjdk.org/jdk/compare/28977972a0129892543222eada4dc99f4cd62574...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@savoptik, @kumarabhi006) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@manukumarvs The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (be88842b)
• 02: Full - Incremental (127c7dcc)
• 01: Full - Incremental (d4d83388)
• 00: Full (4d087a98)

[prrace]

"+ "Using mouse drag the header of the last culumn so the last column becomes the first one.""

culumn -> column

And would it be better to use PassFailJFrame for this test ?

[manukumarvs]

@prrace Yes, it is better to use PassFailJFrame for this test and I have created a bug for the conversion https://bugs.openjdk.org/browse/JDK-8342663. I will work on this. I'm not mixing it with this fix as converting this test alone to use PassFailJFrame may not be feasible as all the tests inside the folder java/awt/a11y has a common abstract parent class AccessibleComponentTest, so it will be better to do the conversion for the whole set of tests inside java/awt/a11y folder together.

[savoptik]

LGTM

[kumarabhi006]

@manukumarvs copyright year need update?
I think@author tag also is not required.

[kumarabhi006]

LGTM.

[manukumarvs]

/integrate

[openjdk]

@manukumarvs
Your change (at version be88842) is now ready to be sponsored by a Committer.

[manukumarvs]

Any sponsors, please?

[savoptik]

/sponsor

[openjdk]

Going to push as commit f1f1537.
Since your change was applied there have been 234 commits pushed to the master branch:

• 476d0f1: 8339309: unused-variable warnings happen in libfontmanager
• d6eddcd: 8327624: Remove VM implementation that bypass verification for core reflection
• 28147da: 8341913: Support CDS heap dumping for Shenandoah and Epsilon
• c61d2c5: 8341445: DecimalFormatSymbols setters should throw NPE
• aafc8d0: 8342850: Change ProblemList to have LimitDirectMemory refer to JDK-8342849
• 893266c: 8342601: AArch64: Micro-optimize bit shift in copy_memory
• f9852ae: 8342839: Malformed copyright in StringNameTable since JDK-8342806
• af5e532: 8342806: Desugar capturing lambda in StringNameTable
• 01b681c: 8326949: Authorization header is removed when a proxy Authenticator is set on HttpClient
• d10eecf: 8341776: Remove unused enum values from LambdaForm$Kind
• ... and 224 more: https://git.openjdk.org/jdk/compare/28977972a0129892543222eada4dc99f4cd62574...master

Your commit was automatically rebased without conflicts.

[openjdk]

@savoptik @manukumarvs Pushed as commit f1f1537.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.