Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8255464: Cannot access ModuleTree in a CompilationUnitTree #2155

Closed
wants to merge 1 commit into from

Conversation

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Jan 20, 2021

Please review a small change to add an overdue missing method to access the ModuleTree when a CompilationUnitTree represents a modular compilation unit.

CSR is in progress.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8255464: Cannot access ModuleTree in a CompilationUnitTree

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2155/head:pull/2155
$ git checkout pull/2155

@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Jan 20, 2021

/csr

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 20, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2021

@jonathan-gibbons this pull request will not be integrated until the CSR request JDK-8255478 for issue JDK-8255464 has been approved.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the compiler label Jan 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 20, 2021

Webrevs

Loading

@openjdk openjdk bot removed the csr label Jan 20, 2021
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

looks good to me

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255464: Cannot access ModuleTree in a CompilationUnitTree

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

  • 5aca934: 8260304: (se) EPollSelectorImpl wakeup mechanism broken on Linux 32-bit
  • 53fecba: 8258805: Japanese characters not entered by mouse click on Windows 10
  • a887177: 8246788: ZoneRules invariants can be broken
  • 874aef4: 8259707: LDAP channel binding does not work with StartTLS extension
  • c5ad713: 8260250: Duplicate check in DebugInformationRecorder::recorders_frozen
  • bf5e801: 8259922: MethodHandles.collectArguments does not throw IAE if pos is outside the arity range
  • 0ea5862: 8260053: Optimize Tokens' use of Names
  • 18eb6d9: 8255348: NPE in PKIXCertPathValidator event logging code
  • a97f3c1: 8258853: Support separate function declaration and definition with ENABLE_IF-based SFINAE
  • 154e1d6: 8259009: G1 heap summary should be shown in "Heap Parameters" window on HSDB
  • ... and 43 more: https://git.openjdk.java.net/jdk/compare/a37cd5a3133d7c66942919655d977912491d5b8c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 22, 2021
@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Jan 25, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@jonathan-gibbons Since your change was applied there have been 83 commits pushed to the master branch:

  • 12ccd21: 8260289: Unable to customize module lists after change JDK-8258411
  • 73c78c8: 8260329: Update references to TAOCP to latest edition
  • 5b0b24b: 8260381: ProblemList com/sun/management/DiagnosticCommandMBean/DcmdMBeanTestCheckJni.java on Win with ZGC
  • 47c7dc7: 8258833: Cancel multi-part cipher operations in SunPKCS11 after failures
  • ef247ab: 8260308: Update LogCompilation junit to 4.13.1
  • d076977: 8260169: LogCompilation: Unexpected method mismatch
  • 6e03735: 8259845: Move placeholder implementation details to cpp file and add logging
  • ca20c63: 8259710: Inlining trace leaks memory
  • 09489e2: 8260338: Some fields in HaltNode is not cloned
  • af155fc: 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo
  • ... and 73 more: https://git.openjdk.java.net/jdk/compare/a37cd5a3133d7c66942919655d977912491d5b8c...master

Your commit was automatically rebased without conflicts.

Pushed as commit d6fb9d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@jonathan-gibbons jonathan-gibbons deleted the ModuleTree branch Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants