Skip to content

8331958: Update PC/SC Lite for Suse Linux to 2.3.0 #21552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

valeriepeng
Copy link
Contributor

@valeriepeng valeriepeng commented Oct 16, 2024

Could someone please help review this PR? It updates the PCSC Lite headers and the relevant files to v2.3.0.

Thanks!
Valerie


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331958: Update PC/SC Lite for Suse Linux to 2.3.0 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21552/head:pull/21552
$ git checkout pull/21552

Update a local copy of the PR:
$ git checkout pull/21552
$ git pull https://git.openjdk.org/jdk.git pull/21552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21552

View PR using the GUI difftool:
$ git pr show -t 21552

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21552.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2024

👋 Welcome back valeriep! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@valeriepeng This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331958: Update PC/SC Lite for Suse Linux to 2.3.0

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 216 new commits pushed to the master branch:

  • 964d8d2: 8340445: [PPC64] Wrong ConditionRegister used in ppc64.ad: flagsRegCR0 cr1
  • 7131f05: 8342043: Split Opaque4Node into OpaqueTemplateAssertionPredicateNode and OpaqueNotNullNode
  • 37cfaa8: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp
  • a1ef818: 8342825: Fix order of @param tags in module java.desktop
  • cdad728: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY
  • 018db8c: 8342809: C2 hits "assert(is_If()) failed: invalid node class: Con" during IGVN due to unhandled top
  • f1f1537: 8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible
  • 476d0f1: 8339309: unused-variable warnings happen in libfontmanager
  • d6eddcd: 8327624: Remove VM implementation that bypass verification for core reflection
  • 28147da: 8341913: Support CDS heap dumping for Shenandoah and Epsilon
  • ... and 206 more: https://git.openjdk.org/jdk/compare/62acc9c174f23acd2807c8214ffc28d73799da16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@valeriepeng The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Oct 16, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2024

Webrevs

@wangweij
Copy link
Contributor

I see there is a COPYING file in the same directory as the header files. Does it need any update?

@valeriepeng
Copy link
Contributor Author

I see there is a COPYING file in the same directory as the header files. Does it need any update?

That file has been the same, so no need to update it.

@wangweij
Copy link
Contributor

If the upstream file hasn’t changed, that’s fine. I was just curious why the year included (for Ludovic) hasn’t been updated as well.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 23, 2024
@valeriepeng
Copy link
Contributor Author

If the upstream file hasn’t changed, that’s fine. I was just curious why the year included (for Ludovic) hasn’t been updated as well.

Yup, same here. Since the upstream file is the same, I only update the changed files.
Thanks for the review~

@valeriepeng
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2024

Going to push as commit d2e716e.
Since your change was applied there have been 274 commits pushed to the master branch:

  • a95374f: 8343101: Rework BasicTest.testTemp test cases
  • 00fe9f7: 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file
  • 9f6d5b4: 8343020: (fs) Add support for SecureDirectoryStream on macOS
  • 1341b81: 8341666: FileInputStream doesn't support readAllBytes() or readNBytes(int) on pseudo devices
  • 52382e2: 8338021: Support new unsigned and saturating vector operators in VectorAPI
  • e659d9d: 8342975: C2: Micro-optimize PhaseIdealLoop::Dominators()
  • 9f6211b: 8341371: CDS cannot load archived heap objects with -XX:+UseSerialGC -XX:-UseCompressedOops
  • 120a935: 8342561: Metaspace for generated reflection classes is no longer needed
  • d5fb6b4: 8339939: [JVMCI] Don't compress abstract and interface Klasses
  • a5ad974: 8343056: C2: Micro-optimize Node lists grow
  • ... and 264 more: https://git.openjdk.org/jdk/compare/62acc9c174f23acd2807c8214ffc28d73799da16...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2024
@openjdk openjdk bot closed this Oct 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2024
@openjdk
Copy link

openjdk bot commented Oct 28, 2024

@valeriepeng Pushed as commit d2e716e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@valeriepeng valeriepeng deleted the JDK-8331958 branch October 28, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants