Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8259897: gtest os.dll_address_to_function_and_library_name_vm fails on AIX #2156

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jan 20, 2021

This is trivial. The test tries to come up with a pointer slightly outside a function but still inside a library, and then to resolve it to a valid library name. This is shaky. On AIX, the pointer had been a function descriptor, stored separately from the code sections, so this won't work.

I removed this part of the test, since this is shaky and relies on UB.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259897: gtest os.dll_address_to_function_and_library_name_vm fails on AIX

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2156/head:pull/2156
$ git checkout pull/2156

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 20, 2021
@openjdk
Copy link

openjdk bot commented Jan 20, 2021

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 20, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2021

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Looks reasonable.

@openjdk
Copy link

openjdk bot commented Jan 21, 2021

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259897: gtest os.dll_address_to_function_and_library_name_vm fails on AIX

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 21, 2021
@tstuefe
Copy link
Member Author

tstuefe commented Jan 21, 2021

Thank you Martin.

/integrate

@openjdk openjdk bot closed this Jan 21, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 21, 2021
@openjdk
Copy link

openjdk bot commented Jan 21, 2021

@tstuefe Since your change was applied there have been 22 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 4dfd8cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe tstuefe deleted the JDK-8259897-gtest-dll_address_to_function_and_library_name-fails-on-AIX branch Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants