8342508: Use latch in BasicMenuUI/bug4983388.java instead of delay

[aivanov-jdk]

Use a CountDownLatch in javax/swing/plaf/basic/BasicMenuUI/4983388/bug4983388.java instead of delay.

The latch provides a direct way to synchronise EDT and main thread, the test will finish quicker.

I ran the updated test a few times with JTREG=REPEAT_COUNT=20, the test always passed in the CI.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342508: Use latch in BasicMenuUI/bug4983388.java instead of delay (Bug - P5)

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer) Review applies to 10b51b09
• @abdelhak-zaaim (no known openjdk.org user name / role) Review applies to 10b51b09
• Alexander Zvegintsev (@azvegint - Reviewer)
• Abhishek Kumar (@kumarabhi006 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21585/head:pull/21585
$ git checkout pull/21585

Update a local copy of the PR:
$ git checkout pull/21585
$ git pull https://git.openjdk.org/jdk.git pull/21585/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21585

View PR using the GUI difftool:
$ git pr show -t 21585

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21585.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342508: Use latch in BasicMenuUI/bug4983388.java instead of delay

Reviewed-by: azvegint, abhiscxk, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• 54a744b: 8340553: ZipEntry field validation does not take into account the size of a CEN header
• 18b55ce: 8342653: Fix minor doc issues in AnnotatedElement
• 153ad91: 8338126: C2 SuperWord: VectorCastF2HF / vcvtps2ph produces wrong results for vector length 2
• 80ec552: 8328528: C2 should optimize long-typed parallel iv in an int counted loop
• 330f2b5: 8342295: compiler/jvmci/TestJVMCISavedProperties.java fails due to garbage in output
• 1f35748: 8342102: ZGC: Optimize copy constructors in ZPhysicalMemory
• 66ddaaa: 8340241: RISC-V: Returns mispredicted
• 07f550b: 8340818: Add a new jtreg test root to test the generated documentation
• 27ef6c9: 8341470: BigDecimal.stripTrailingZeros() optimization
• 5d5d88a: 8339570: Add Tidy build support for JDK tests
• ... and 37 more: https://git.openjdk.org/jdk/compare/3ebfc6c1e27119180700af5ea85e5fa6c1771050...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (616627e9)
• 01: Full - Incremental (53d03a32)
• 00: Full (10b51b09)

[kumarabhi006]

Looks ok to me except for a suggestion.

[bridgekeeper]

@aivanov-jdk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[aivanov-jdk]

Hi @aivanov-jdk, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user aivanov-jdk" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

• I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

[openjdk]

Going to push as commit 02ec8ca.
Since your change was applied there have been 531 commits pushed to the master branch:

• 47ebf8d: 8342098: Write a test to compare the images
• 78602be: 8344024: Unnecessary Hashtable usage in RSAPSSSignature.DIGEST_LENGTHS
• 7f672eb: 8344550: Compilation error of jpackage test JPackageStringBundle.java source
• 48223f7: 8344143: Test jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macosx-x64
• d4cd27e: 8344445: MethodCounters don't need a vptr
• dc940ec: 8344387: RISC-V: C2: Improve encoding of LoadNKlass for compact headers
• ded01e4: 8344327: SM cleanup in jdk.unsupported ReflectionFactory
• 59fcfae: 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values
• 1717946: 8344302: G1: Refactor G1CMTask::do_marking_step to use smaller wrapper methods
• fea5f2b: 8344415: Restruct jpackage utility classes
• ... and 521 more: https://git.openjdk.org/jdk/compare/3ebfc6c1e27119180700af5ea85e5fa6c1771050...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit 02ec8ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.