8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option

[sendaoYan]

Hi all,
Newly added test gc/shenandoah/compiler/TestLoadBypassesNullCheck.java fails The unlock option must precede 'StressGCM'. with release jdk build. This PR fix the test bug, only add -XX:+UnlockDiagnosticVMOptions to make test run passed by release jdk build.
The change has been verified locally with release/fastdebug/slowdebug on linux-x64. Test-fix only, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option (Bug - P3)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21609/head:pull/21609
$ git checkout pull/21609

Update a local copy of the PR:
$ git checkout pull/21609
$ git pull https://git.openjdk.org/jdk.git pull/21609/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21609

View PR using the GUI difftool:
$ git pr show -t 21609

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21609.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 51a7ff6: 8335271: Specify the MessageFormat ArgumentIndex Implementation Limit
• 52d752c: 8339507: Test generation tool and gtest for testing APX encoding of extended gpr instructions
• 37aa320: 8342376: More reliable OOM handling in ExceptionDuringDumpAtObjectsInitPhase test
• 18bcbf7: 8341052: SHA-512 implementation using SHA-NI
• 54a744b: 8340553: ZipEntry field validation does not take into account the size of a CEN header
• 18b55ce: 8342653: Fix minor doc issues in AnnotatedElement
• 153ad91: 8338126: C2 SuperWord: VectorCastF2HF / vcvtps2ph produces wrong results for vector length 2
• 80ec552: 8328528: C2 should optimize long-typed parallel iv in an int counted loop
• 330f2b5: 8342295: compiler/jvmci/TestJVMCISavedProperties.java fails due to garbage in output
• 1f35748: 8342102: ZGC: Optimize copy constructors in ZPhysicalMemory
• ... and 1 more: https://git.openjdk.org/jdk/compare/07f550b85a3910edd28d8761e2adfb8d6a1352f6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b7237e8e)
• 00: Full (43731b9e)

[shipilev]

Thank you!

[sendaoYan]

Thanks for the review.

[sendaoYan]

To make CI test less noisy, I will integrate right now, ignore the 24 hours rule. Test-fix only, no risk.
/integrate

[openjdk]

Going to push as commit 8bcd492.
Since your change was applied there have been 17 commits pushed to the master branch:

• 7133d1b: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
• 8276a41: 8342715: x86 unused orw instruction encoding could be removed
• 5a4b180: 8342011: Conditionally compile ReservedHeapSpace compressed heap support
• e0c6480: 8338570: sun/font/HBShaper - mismatch in return type of FFM upcall function description and native invocation
• 7158322: 8340477: Remove JDK1.1 compatible behavior for "EST", "MST", and "HST" time zones
• 97c9212: 8342698: Fix order of @param tags in module java.base
• 51a7ff6: 8335271: Specify the MessageFormat ArgumentIndex Implementation Limit
• 52d752c: 8339507: Test generation tool and gtest for testing APX encoding of extended gpr instructions
• 37aa320: 8342376: More reliable OOM handling in ExceptionDuringDumpAtObjectsInitPhase test
• 18bcbf7: 8341052: SHA-512 implementation using SHA-NI
• ... and 7 more: https://git.openjdk.org/jdk/compare/07f550b85a3910edd28d8761e2adfb8d6a1352f6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 8bcd492.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.