Skip to content

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jan 20, 2021

Few problemlisted test
javax/swing/plaf/basic/Test6984643.java
javax/swing/JMenuItem/6249972/bug6249972.java
javax/swing/JTree/6263446/bug6263446.java
were unstable in mach5 nightly testing. These can be deproblemlisted now with appropriate stability fixes.
Mach5 jobs running for several iterations for all these tests in all platforms is ok. Link in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2161/head:pull/2161
$ git checkout pull/2161

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 20, 2021
@openjdk
Copy link

openjdk bot commented Jan 20, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Jan 20, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 21, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260035: Deproblemlist few problemlisted test

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 21, 2021
@mrserb
Copy link
Member

mrserb commented Jan 21, 2021

Does the JDK-8198340 bug is a test issue?

@prsadhuk
Copy link
Contributor Author

Does the JDK-8198340 bug is a test issue?

Could be...It shows
Caused by: java.lang.IllegalStateException: Shutdown in progress
which I think could be caused by invokeLater so that test tried to do the execution when the main is actually finishing.

@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Jan 21, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 21, 2021
@openjdk
Copy link

openjdk bot commented Jan 21, 2021

@prsadhuk Since your change was applied there have been 49 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 7f7166d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8260035 branch January 21, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated swing client-libs-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants