8342701: [PPC64] TestOSRLotsOfLocals.java crashes

[TheRealMDoerr]

Fix for "assert(nbits == 32 || (-(1 << (nbits-1)) <= x && x < (1 << (nbits-1)))) failed: value out of range" in new test "TestOSRLotsOfLocals" (see JBS).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342701: [PPC64] TestOSRLotsOfLocals.java crashes (Bug - P3)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer)
• Richard Reingruber (@reinrich - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21613/head:pull/21613
$ git checkout pull/21613

Update a local copy of the PR:
$ git checkout pull/21613
$ git pull https://git.openjdk.org/jdk.git pull/21613/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21613

View PR using the GUI difftool:
$ git pr show -t 21613

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21613.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342701: [PPC64] TestOSRLotsOfLocals.java crashes

Reviewed-by: lucy, rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 004aaea: 8342330: C2: "node pinned on loop exit test?" assert failure
• c9f3840: 8342679: Clean up PreviewFeature.Feature
• 2da7f2b: 8342787: Move misplaced TestTemplateAssertionPredicateWithTwoUCTs.java from src to test directory
• de441c2: 8342633: javax/management/security/HashedPasswordFileTest.java creates tmp file in src dir
• bf92c49: 8342704: GHA: Report truncation is broken after JDK-8341424
• 8bcd492: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option
• 7133d1b: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
• 8276a41: 8342715: x86 unused orw instruction encoding could be removed
• 5a4b180: 8342011: Conditionally compile ReservedHeapSpace compressed heap support
• e0c6480: 8338570: sun/font/HBShaper - mismatch in return type of FFM upcall function description and native invocation
• ... and 10 more: https://git.openjdk.org/jdk/compare/330f2b5a9cad02b8e6882fc6eee996d7792d3de1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@TheRealMDoerr The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (752cca98)

[RealLucy]

Looks good to me.

[reinrich]

Looks good.

[TheRealMDoerr]

Thanks for the reviews!

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit 3bba0f3.
Since your change was applied there have been 23 commits pushed to the master branch:

• 264d701: 8342610: ZGC: Cleanup pre-touching code
• f70ecc2: 8342182: G1: G1OldGenAllocationTracker does not account for direct allocations in regions
• 3b71657: 8341584: Test java/foreign/TestUpcallStress.java intermittent timeout with -Xcomp
• 004aaea: 8342330: C2: "node pinned on loop exit test?" assert failure
• c9f3840: 8342679: Clean up PreviewFeature.Feature
• 2da7f2b: 8342787: Move misplaced TestTemplateAssertionPredicateWithTwoUCTs.java from src to test directory
• de441c2: 8342633: javax/management/security/HashedPasswordFileTest.java creates tmp file in src dir
• bf92c49: 8342704: GHA: Report truncation is broken after JDK-8341424
• 8bcd492: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option
• 7133d1b: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
• ... and 13 more: https://git.openjdk.org/jdk/compare/330f2b5a9cad02b8e6882fc6eee996d7792d3de1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 3bba0f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.