JDK-8342635 : javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir

[honkar-jdk]

WindowsDefaultIconSizeTest.java and WBMPStreamTruncateTest.java updated to store the tmp file in test scratch dir (default location) instead of test src dir.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir (Bug - P3)
• JDK-8342634: javax/imageio/plugins/wbmp/WBMPStreamTruncateTest.java creates temp file in src dir (Bug - P4)

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer) Review applies to 32c58248
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21619/head:pull/21619
$ git checkout pull/21619

Update a local copy of the PR:
$ git checkout pull/21619
$ git pull https://git.openjdk.org/jdk.git pull/21619/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21619

View PR using the GUI difftool:
$ git pr show -t 21619

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21619.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir
8342634: javax/imageio/plugins/wbmp/WBMPStreamTruncateTest.java creates temp file in src dir

Reviewed-by: erikj, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 191 new commits pushed to the master branch:

• 9a9ac1d: 8341927: Replace hardcoded security providers with new test.provider.name system property
• 1b177ce: 8343103: Enable debug logging for vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java
• 7404ddf: 8202100: Merge vm/share/InMemoryJavaCompiler w/ jdk/test/lib/compiler/InMemoryJavaCompiler
• 821c514: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode
• 0fe15d6: 8343040: Clean up references to JRE in the launcher code
• 9003524: 8342588: Shenandoah: Pull shared closures together in one header
• f7f5198: 8343186: hsdis build libopcodes and libbfd are not found
• 63c19d3: 8341977: Replace predicate walking and cloning code for Loop Peeling with a predicate visitor
• 158ae51: 8250659: Clarify in ParameterizedType.getRawType() doc that only Class is returned
• b6f745d: 8342489: compiler/c2/irTests/TestVectorizationMismatchedAccess.java fails on big-endian platforms
• ... and 181 more: https://git.openjdk.org/jdk/compare/d4f0ba73f653a3886b17f283b9b6a92db1af52aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@honkar-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (fe2b29cd)
• 01: Full - Incremental (32c58248)
• 00: Full (b338b4a7)

[honkar-jdk]

/issue add JDK-8342634

[openjdk]

@honkar-jdk
Adding additional issue to issue list: 8342634: javax/imageio/plugins/wbmp/WBMPStreamTruncateTest.java creates temp file in src dir.

[honkar-jdk]

@erikj79 Can you please review these two test updates w.r.t CI changes

[honkar-jdk]

/integrate

[openjdk]

Going to push as commit 02ea4b5.
Since your change was applied there have been 192 commits pushed to the master branch:

• 7461dfe: 8341788: Fix ExceptionOccurred in hotspot
• 9a9ac1d: 8341927: Replace hardcoded security providers with new test.provider.name system property
• 1b177ce: 8343103: Enable debug logging for vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java
• 7404ddf: 8202100: Merge vm/share/InMemoryJavaCompiler w/ jdk/test/lib/compiler/InMemoryJavaCompiler
• 821c514: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode
• 0fe15d6: 8343040: Clean up references to JRE in the launcher code
• 9003524: 8342588: Shenandoah: Pull shared closures together in one header
• f7f5198: 8343186: hsdis build libopcodes and libbfd are not found
• 63c19d3: 8341977: Replace predicate walking and cloning code for Loop Peeling with a predicate visitor
• 158ae51: 8250659: Clarify in ParameterizedType.getRawType() doc that only Class is returned
• ... and 182 more: https://git.openjdk.org/jdk/compare/d4f0ba73f653a3886b17f283b9b6a92db1af52aa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@honkar-jdk Pushed as commit 02ea4b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.