8340177: Malformed system classes loaded by bootloader crash the JVM in product builds

[dholmes-ora]

For core classes where verification is by default disabled, product builds would check for parsing/verification constraint violations but then ignore them. In contrast a debug build would check and report them even if verification were disabled. To make it easier for developers testing in product mode predominantly we changed the behaviour so that these constraints are always checked and reported. The intent was for product builds to run faster by skipping the checks, but in practice that doesn't happen - see bug report for background details.

The simple fix is to replace check_property calls with guarantee_property.

Testing:

• tiers 1-4
• basic performance/footprint testing (no significant changes)

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340177: Malformed system classes loaded by bootloader crash the JVM in product builds (Enhancement - P4)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Hamlin Li (@Hamlin-Li - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21626/head:pull/21626
$ git checkout pull/21626

Update a local copy of the PR:
$ git checkout pull/21626
$ git pull https://git.openjdk.org/jdk.git pull/21626/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21626

View PR using the GUI difftool:
$ git pr show -t 21626

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21626.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340177: Malformed system classes loaded by bootloader crash the JVM in product builds

Reviewed-by: coleenp, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

• 7131f05: 8342043: Split Opaque4Node into OpaqueTemplateAssertionPredicateNode and OpaqueNotNullNode
• 37cfaa8: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp
• a1ef818: 8342825: Fix order of @param tags in module java.desktop
• cdad728: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY
• 018db8c: 8342809: C2 hits "assert(is_If()) failed: invalid node class: Con" during IGVN due to unhandled top
• f1f1537: 8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible
• 476d0f1: 8339309: unused-variable warnings happen in libfontmanager
• d6eddcd: 8327624: Remove VM implementation that bypass verification for core reflection
• 28147da: 8341913: Support CDS heap dumping for Shenandoah and Epsilon
• c61d2c5: 8341445: DecimalFormatSymbols setters should throw NPE
• ... and 42 more: https://git.openjdk.org/jdk/compare/76ae072a1fec5f2af4ac4c633bc67a0c4c756a90...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ce97bd56)

[coleenp]

This is nice plus a bonus cleanup. Thanks!

[dholmes-ora]

Thanks for the review @coleenp !

[Hamlin-Li]

Looks good!

[dholmes-ora]

Thanks for the review @Hamlin-Li

/integrate

[openjdk]

Going to push as commit 28d23ad.
Since your change was applied there have been 62 commits pushed to the master branch:

• 98403b7: 8342854: [JVMCI] Block secondary thread reporting a JVMCI fatal error
• 9a7a850: 8341939: SigningOptionsTest fails without Xcode with command line developer tools after JDK-8341443
• de92fe3: 8233451: (fs) Files.newInputStream() cannot be used with character special files
• 002de86: 8342673: Test serviceability/jvmti/events/NotifyFramePopStressTest/NotifyFramePopStressTest.java failed: waited too long for notify
• a21c558: 8342863: Use pattern matching for instanceof in equals methods of wrapper classes
• e64f079: 8342582: user.region for formatting number no longer works for 21.0.5
• 426da4b: 8341975: Unable to set encoding for IO.println, IO.print and IO.readln
• a522d21: 8342858: Make target mac-jdk-bundle fails on chmod command
• afb62f7: 8342683: Use non-short forward jump when passing stop()
• 964d8d2: 8340445: [PPC64] Wrong ConditionRegister used in ppc64.ad: flagsRegCR0 cr1
• ... and 52 more: https://git.openjdk.org/jdk/compare/76ae072a1fec5f2af4ac4c633bc67a0c4c756a90...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit 28d23ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.