8260048: Shenandoah: ShenandoahMarkingContext asserts are unnecessary

[shipilev]

There are two shenandoah_assert_not_forwarded asserts that are not necessary in mark_{strong,weak}, because the only caller already asserts this higher-level invariant. There is no need to check it in ShenandoahMarkingContext once again. This simplifies the fastpath in fastdebug builds.

Additional testing:

• hotspot_gc_shenandoah
• tier1, tier2 with Shenandoah

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260048: Shenandoah: ShenandoahMarkingContext asserts are unnecessary

Reviewers

• Zhengyu Gu (@zhengyu123 - Reviewer)
• Roman Kennke (@rkennke - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2164/head:pull/2164
$ git checkout pull/2164

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (935e548)

[zhengyu123]

Looks good and trivial.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260048: Shenandoah: ShenandoahMarkingContext asserts are unnecessary

Reviewed-by: zgu, rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 0785147: 8259949: x86 32-bit build fails when -fcf-protection is passed in the compiler flags
• 5891509: 8259947: (fs) Optimize UnixPath.encode implementation
• 69f90b5: 8259843: initialize dli_fname array before calling dll_address_to_library_name
• 52ed2aa: 8259786: initialize last parameter of getpwuid_r
• 70b5b31: 8257664: HTMLEditorKit: Wrong CSS relative font sizes
• 0b01d69: 8260005: Shenandoah: Remove unused AlwaysTrueClosure in ShenandoahConcurrentRootScanner::roots_do()
• 0529480: 8259867: Move encoding checks into ZipCoder
• 7c32ffe: 8258383: vmTestbase/gc/g1/unloading/tests/unloading_compilation_level[1,2,3] time out without TieredCompilation
• 9f21bb6: 8259983: do not use uninitialized expand_ms value in G1CollectedHeap::expand_heap_after_young_collection
• cf25383: Merge
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/a9519c83b8f118f62190a3956fca6c45387c7d6b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rkennke]

Ok.

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there have been 29 commits pushed to the master branch:

• f8a9602: 8260025: Missing comma in VM_Version_Ext::_family_id_amd
• 133bcb0: Merge
• 0408b23: 8259757: add a regression test for 8259353 and 8259601
• 0120510: 8259732: JDK 16 L10n resource file update - msg drop 10
• 044bae0: 8260191: Do not include access.hpp in oop.hpp
• 77a4302: 8223056: Remove Type-Stable-Memory support for Parkers
• 35c9da7: 8259498: Reduce overhead of MD5 and SHA digests
• 27cc62a: 8259911: byteArrayViewVarHandle should throw ArrayIndexOutOfBoundsException
• 1f47de5: 8260010: UTF8ZipCoder not thread-safe since JDK-8243469
• 8b95d95: 8256895: Add support for RFC 8954: Online Certificate Status Protocol (OCSP) Nonce Extension
• ... and 19 more: https://git.openjdk.java.net/jdk/compare/a9519c83b8f118f62190a3956fca6c45387c7d6b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 5940287.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.