8342854: [JVMCI] Block secondary thread reporting a JVMCI fatal error

[dougxc]

A fatal crash on a second thread causes the thread to sleep infinitely while error reporting continues on the first crashing thread. The same should be done for reporting fatal crashes in libjvmci to avoid interleaving reports. This PR implements this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342854: [JVMCI] Block secondary thread reporting a JVMCI fatal error (Bug - P4)

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21646/head:pull/21646
$ git checkout pull/21646

Update a local copy of the PR:
$ git checkout pull/21646
$ git pull https://git.openjdk.org/jdk.git pull/21646/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21646

View PR using the GUI difftool:
$ git pr show -t 21646

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21646.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342854: [JVMCI] Block secondary thread reporting a JVMCI fatal error

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 444 new commits pushed to the master branch:

• de92fe3: 8233451: (fs) Files.newInputStream() cannot be used with character special files
• 002de86: 8342673: Test serviceability/jvmti/events/NotifyFramePopStressTest/NotifyFramePopStressTest.java failed: waited too long for notify
• a21c558: 8342863: Use pattern matching for instanceof in equals methods of wrapper classes
• e64f079: 8342582: user.region for formatting number no longer works for 21.0.5
• 426da4b: 8341975: Unable to set encoding for IO.println, IO.print and IO.readln
• a522d21: 8342858: Make target mac-jdk-bundle fails on chmod command
• afb62f7: 8342683: Use non-short forward jump when passing stop()
• 964d8d2: 8340445: [PPC64] Wrong ConditionRegister used in ppc64.ad: flagsRegCR0 cr1
• 7131f05: 8342043: Split Opaque4Node into OpaqueTemplateAssertionPredicateNode and OpaqueNotNullNode
• 37cfaa8: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp
• ... and 434 more: https://git.openjdk.org/jdk/compare/9176f6810ef914579b8ca8e3bc20a0fdf3a934c8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a5a98b3b)

[tkrodriguez]

Looks good.

[dougxc]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 98403b7.
Since your change was applied there have been 445 commits pushed to the master branch:

• 9a7a850: 8341939: SigningOptionsTest fails without Xcode with command line developer tools after JDK-8341443
• de92fe3: 8233451: (fs) Files.newInputStream() cannot be used with character special files
• 002de86: 8342673: Test serviceability/jvmti/events/NotifyFramePopStressTest/NotifyFramePopStressTest.java failed: waited too long for notify
• a21c558: 8342863: Use pattern matching for instanceof in equals methods of wrapper classes
• e64f079: 8342582: user.region for formatting number no longer works for 21.0.5
• 426da4b: 8341975: Unable to set encoding for IO.println, IO.print and IO.readln
• a522d21: 8342858: Make target mac-jdk-bundle fails on chmod command
• afb62f7: 8342683: Use non-short forward jump when passing stop()
• 964d8d2: 8340445: [PPC64] Wrong ConditionRegister used in ppc64.ad: flagsRegCR0 cr1
• 7131f05: 8342043: Split Opaque4Node into OpaqueTemplateAssertionPredicateNode and OpaqueNotNullNode
• ... and 435 more: https://git.openjdk.org/jdk/compare/9176f6810ef914579b8ca8e3bc20a0fdf3a934c8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit 98403b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.