8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree #21665

fguallini · 2024-10-23T14:46:37Z

The test sun/security/pkcs11/Provider/RequiredMechCheck.java extends sun/security/pkcs11/PKCS11Test.java, which sets up a PKCS11Provider configured with NSS config files located in the source tree directory (sun/security/pkcs11/nss) for the dependent tests to run properly. This test currently fails if that pkcs11/nss directory is made read-only because these config files are updated during the test execution. Files located in the source tree should not be modified when running tests.
This PR updates the PKCS11Test to copy the NSS config files to the Jtreg scratch directory and configures the provider to use those files instead.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree (Bug - P3)

Reviewers

Erik Joelsson (@erikj79 - Reviewer) Review applies to 121de0aa
Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21665/head:pull/21665
$ git checkout pull/21665

Update a local copy of the PR:
$ git checkout pull/21665
$ git pull https://git.openjdk.org/jdk.git pull/21665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21665

View PR using the GUI difftool:
$ git pr show -t 21665

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21665.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-10-23T14:47:19Z

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-10-23T14:47:32Z

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree

Reviewed-by: rhalade, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 205 new commits pushed to the master branch:

6811a11: 8341408: Implement JEP 488: Primitive Types in Patterns, instanceof, and switch (Second Preview)
72a45dd: 8341834: C2 compilation fails with "bad AD file" due to Replicate
57c3bb6: 8343068: C2: CastX2P Ideal transformation not always applied
83f3d42: 8339303: C2: dead node after failing to match cloned address expression
ead0116: 8331341: secondary_super_cache does not scale well: C1 and interpreter
06d8216: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux
bdd6816: 8343502: RISC-V: SIGBUS in updateBytesCRC32 after JDK-8339738
4431852: 8342943: Replace predicate walking and cloning code for main/post loops with a predicate visitor
1b0281d: 8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows
471f112: 8342577: Clean up JVMTI breakpoint support
... and 195 more: https://git.openjdk.org/jdk/compare/893266c48f26e089d0449d2c161b04430741970c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2024-10-23T14:48:21Z

@fguallini The following label will be automatically applied to this pull request:

security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-10-23T16:55:26Z

Webrevs

01: Full - Incremental (1b1eae95)
00: Full (121de0aa)

rhalade · 2024-10-23T19:50:19Z

test/jdk/sun/security/pkcs11/PKCS11Test.java

@@ -247,6 +247,30 @@ public static String getBase() throws Exception {
        return PKCS11_BASE;
    }

+    private static void copyFiles(Path source, String destination)


Check jdk.test.lib if there is a method you can use to copy files. If not then this method should be added to library.

Updated to use the existing Utils.copyFile, it was also needed to add the dependency in a shell test that uses PKCS11Test.java

rhalade · 2024-10-23T19:51:24Z

test/jdk/sun/security/pkcs11/PKCS11Test.java

@@ -497,13 +521,17 @@ public static String getNssConfig() throws Exception {
        }

        String base = getBase();
+        String nss = "nss";
+        Path nssDirSource = Path.of(base).resolve(nss);
+        String nssDirDestination = Path.of(".").resolve(nss).toString();


Using current directory here may be incorrect. Can this be changed to Path.of(System.getProperty("test.classes"), ".")

The "test.classes" directory only contains the compiled classes according to jtreg doc.
Whereas, the current directory is the Jtreg scratch directory, which is the right place for the tests temporary files. Also, Jtreg will automatically clean this directory when the test begins.
The scratch directory does seem like the best place to store these temporary configuration files.

fguallini · 2024-11-06T16:22:59Z

/integrate

openjdk · 2024-11-06T16:23:36Z

@fguallini
Your change (at version 1b1eae9) is now ready to be sponsored by a Committer.

rhalade · 2024-11-06T18:35:01Z

/sponsor

openjdk · 2024-11-06T18:36:05Z

Going to push as commit 342fe42.
Since your change was applied there have been 208 commits pushed to the master branch:

78b378a: 8342540: InterfaceCalls micro-benchmark gives misleading results
c0e6c3b: 8343214: Fix encoding errors in APX New Data Destination Instructions Support
0be7118: 8279016: JFR Leak Profiler is broken with Shenandoah
6811a11: 8341408: Implement JEP 488: Primitive Types in Patterns, instanceof, and switch (Second Preview)
72a45dd: 8341834: C2 compilation fails with "bad AD file" due to Replicate
57c3bb6: 8343068: C2: CastX2P Ideal transformation not always applied
83f3d42: 8339303: C2: dead node after failing to match cloned address expression
ead0116: 8331341: secondary_super_cache does not scale well: C1 and interpreter
06d8216: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux
bdd6816: 8343502: RISC-V: SIGBUS in updateBytesCRC32 after JDK-8339738
... and 198 more: https://git.openjdk.org/jdk/compare/893266c48f26e089d0449d2c161b04430741970c...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-11-06T18:36:15Z

@rhalade @fguallini Pushed as commit 342fe42.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

copy nss files to working dir

b7f61f8

openjdk bot added the security security-dev@openjdk.org label Oct 23, 2024

fguallini added 2 commits October 23, 2024 16:51

renamed copyNssFiles to copyFiles

e94e2f2

Merge branch 'master' into 8342270

121de0a

fguallini marked this pull request as ready for review October 23, 2024 16:52

openjdk bot added the rfr Pull request is ready for review label Oct 23, 2024

erikj79 approved these changes Oct 23, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 23, 2024

rhalade suggested changes Oct 23, 2024

View reviewed changes

Reusing Utils.CopyFiles

1b1eae9

openjdk bot removed the ready Pull request is ready to be integrated label Oct 24, 2024

fguallini requested a review from rhalade November 4, 2024 10:27

rhalade approved these changes Nov 4, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 4, 2024

openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 6, 2024

openjdk bot added the integrated Pull request has been integrated label Nov 6, 2024

openjdk bot closed this Nov 6, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 6, 2024

rhalade mentioned this pull request Feb 12, 2025

8349535: Refactor ./pkcs11/Provider/MultipleLogins.sh to java test #23590

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree #21665

8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree #21665

Uh oh!

fguallini commented Oct 23, 2024 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Oct 23, 2024

Uh oh!

openjdk bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

openjdk bot commented Oct 23, 2024

Uh oh!

mlbridge bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

rhalade Oct 23, 2024

Uh oh!

fguallini Oct 24, 2024

Uh oh!

rhalade Oct 23, 2024

Uh oh!

fguallini Oct 24, 2024 •

edited

Loading

Uh oh!

fguallini commented Nov 6, 2024

Uh oh!

openjdk bot commented Nov 6, 2024

Uh oh!

rhalade commented Nov 6, 2024

Uh oh!

openjdk bot commented Nov 6, 2024

Uh oh!

openjdk bot commented Nov 6, 2024

Uh oh!

Uh oh!

8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree #21665

8342270: Test sun/security/pkcs11/Provider/RequiredMechCheck.java needs write access to src tree #21665

Uh oh!

Conversation

fguallini commented Oct 23, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Oct 23, 2024

Uh oh!

openjdk bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Oct 23, 2024

Uh oh!

mlbridge bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

rhalade Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

fguallini Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

rhalade Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

fguallini Oct 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fguallini commented Nov 6, 2024

Uh oh!

openjdk bot commented Nov 6, 2024

Uh oh!

rhalade commented Nov 6, 2024

Uh oh!

openjdk bot commented Nov 6, 2024

Uh oh!

openjdk bot commented Nov 6, 2024

Uh oh!

Uh oh!

fguallini commented Oct 23, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Oct 23, 2024 •

edited

Loading

mlbridge bot commented Oct 23, 2024 •

edited

Loading

fguallini Oct 24, 2024 •

edited

Loading